feat: add ability to configure automatic loading of new files over 10000#1349
Open
socalledtheraven wants to merge 5 commits intoTagStudioDev:mainfrom
Open
feat: add ability to configure automatic loading of new files over 10000#1349socalledtheraven wants to merge 5 commits intoTagStudioDev:mainfrom
socalledtheraven wants to merge 5 commits intoTagStudioDev:mainfrom
Conversation
CyanVoxel
added
Type: Enhancement
CyanVoxel
requested changes
May 8, 2026
Member
There was a problem hiding this comment.
Note: You can ignore the current MyPy error as that's an issue with an unrelated library that pushed a breaking change and has already been resolved on the main branch.
Thank you for your work on this pull request!
Overall things look good, I just have a few comments that largely revolve around the suggestion to use the terminology "scan_files_on_open" instead of "autoload_new_files"/"auto_load_new_files" as it's more descriptive and consistent with the existing terminology in the program.
Co-authored-by: Travis Abendshien <46939827+CyanVoxel@users.noreply.github.com>
Co-authored-by: Travis Abendshien <46939827+CyanVoxel@users.noreply.github.com>
Co-authored-by: Travis Abendshien <46939827+CyanVoxel@users.noreply.github.com>
Author
|
Changes made! |
CyanVoxel
reviewed
May 9, 2026
Member
CyanVoxel
left a comment
CyanVoxel
left a comment
There was a problem hiding this comment.
Awesome!! Thank you so much for the quick changes!
| # TODO - make this call optional | ||
| if self.lib.entries_count < 10000: | ||
| if self.settings.scan_files_on_open: | ||
| self.add_new_files_callback() |
Member
There was a problem hiding this comment.
Accidentally duplicated line ;)
Suggested change
| self.add_new_files_callback() |
CyanVoxel
moved this from 🏓 Ready for Review
to 🍃 Pending Merge
in TagStudio Development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added an option to reenable the ability to automatically load new files added to the library when over 10,000 are already present.
resolves #1348
Tasks Completed