[Tests] Remove filesystem mocks in git.test.ts#7514
Conversation
Refactor git.test.ts to use inTemporaryDirectory instead of mocking the filesystem.
This improves test reliability by verifying actual behavior on disk rather than
implementation details like call counts on mocked functions.
- Removed vi.mock('./fs.js')
- Refactored downloadGitRepository tests to use real directories and files
- Refactored createGitIgnore tests to verify file content on disk
- Cleaned up unused imports and fixed formatting
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
github-actions
Bot
added
the
no-changelog
Merge activity
|
gonzaloriestra
deleted the
tester-remove-git-test-fs-mocks-1108447129653858516
branch
2 participants
WHY are these changes introduced?
Following the "Tester" mission to improve test quality by removing filesystem mocks. Mocking the filesystem is considered a "bad test" pattern when a real temporary directory can be used, as it tests implementation details rather than behavior.
WHAT is this pull request doing?
Refactors
packages/cli-kit/src/public/node/git.test.tsto:vi.mock('./fs.js')which partially mocked filesystem operations.inTemporaryDirectory.downloadGitRepositoryandcreateGitIgnoreto set up real files/directories and assert on the resulting filesystem state.How to test your changes?
CI
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 1108447129653858516 started by @gonzaloriestra