Update dependencies and declare node 24 as runtime#525
Open
jpraetorius wants to merge 5 commits intoSamKirkland:masterfrom
Open
Update dependencies and declare node 24 as runtime#525jpraetorius wants to merge 5 commits intoSamKirkland:masterfrom
jpraetorius wants to merge 5 commits intoSamKirkland:masterfrom
Conversation
- move to current versions on all dependencies - `@actions/core` is pinned to 2.0.2 as version 3 has issues with `ncc` - move all test dependencies into `devDependencies` - update esline config to match the expected new style (setup copied from the old configuration)
Owner
|
Lots of good changes here including package.json cleanup that's long overdue. I don't have a ton of time on my hands to fully test these changes - in the meantime to unblock you & others i've pulled out the node24 upgrade into it's own PR and merged it. v4.4.0 is now live using node24+ |
Author
|
If I can provide any support in getting this tested in a way that makes you confident to merge stuff I'm happy to help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Sam
like many others I'm currently getting warnings about this action declaring
node20as its runtime on GitHub.So I've taken the time to update all the dependencies and adjust what needed adjusting (mostly eslint config, and a bit of the import style / typescript config) to make things compile again on the updated dependency stack – to then be able to declare node24 as runtime.
Checked it locally as far as I could and it runs with node25 like a charm.
I'd appreciate if you could take a look and cut a new version, so we can get rid of those pesky warnings.
Cheers
Joachim