Add note about xz requirement for tarball in install-nix.md#1119
Merged
Mic92 merged 1 commit intoNixOS:masterfrom Apr 7, 2025
thadguidry:patch-1
Merged
Add note about xz requirement for tarball in install-nix.md#1119Mic92 merged 1 commit intoNixOS:masterfrom thadguidry:patch-1
Mic92 merged 1 commit intoNixOS:masterfrom
thadguidry:patch-1
Conversation
Since we're providing for download `.tar.xz` binary tarballs, we assume that systems have xz-utils or similar for handling that compression format. We should make a note of this small requirement at the beginning of the Install Nix page. Ref for WSL : ``` PS C:\Users\thadg> wsl thad@MarsOrBust:/mnt/c/Users/thadg$ curl -L https://nixos.org/nix/install | sh -s -- --daemon % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- 0:00:03 --:--:-- 0 100 4267 100 4267 0 0 880 0 0:00:04 0:00:04 --:--:-- 5216 sh: you do not have 'xz' installed, which I need to unpack the binary tarball ``` Fixed after running `sudo apt install xz-utils` for my Debian distribution with WSL
jfly
reviewed
Mar 16, 2025
Contributor
jfly
left a comment
There was a problem hiding this comment.
Thanks! I personally not convinced it's a good idea to duplicate the dependencies (which could change over time) here vs the source of truth (the installer itself).
That said, waiting for a whole download just to get an error message is not very nice. How about we move the checks for missing dependencies to the top of the install script instead? Then people will find out about missing dependencies immediately.
I could also see putting a more generic note here saying something like "Note: the installer may error our if you're missing dependencies".
Contributor
Author
|
Agree! Feel free to hack on this PR, or close it with another for improvements on the script as you suggest. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we're providing for download
.tar.xzbinary tarballs, we assume that systems have xz-utils or similar for handling that compression format. We should make a note of this small requirement at the beginning of the Install Nix page.Ref for WSL :
Fixed after running
sudo apt install xz-utilsfor my Debian distribution with WSL