Fix bundle_artifacts to honor Overrides.toml#1089
Open
asinghvi17 wants to merge 1 commit intoJuliaLang:kc/distrofrom
Open
Fix bundle_artifacts to honor Overrides.toml#1089asinghvi17 wants to merge 1 commit intoJuliaLang:kc/distrofrom
asinghvi17 wants to merge 1 commit intoJuliaLang:kc/distrofrom
Conversation
bundle_artifacts had two bugs that caused it to ignore artifact overrides: 1. UUID-based overrides were never processed because _collect_artifacts and bundle_artifacts called select_downloadable_artifacts without pkg_uuid, so process_overrides was never invoked to convert UUID-based entries into hash lookups. 2. The copy loop used basename(artifact_path) as the destination directory name. For overridden artifacts the path is something like /tmp/bzip2_override, so basename gives "bzip2_override" instead of the hash. The distribution's Artifacts.toml still references the original hash, so the artifact wasn't found at runtime. Fix by: - Threading pkg_uuid through _collect_artifacts and bundle_artifacts - Storing the artifact hash alongside the resolved path and using it directly in the copy loop instead of basename Add a test that sets up a UUID-based override with a marker file and verifies bundle_artifacts copies the overridden content under the correct hash directory name. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bundle_artifactsto correctly bundle overridden artifacts fromOverrides.tomlpkg_uuidkwarg), and the copy loop usedbasename(artifact_path)instead of the known hash (so overridden paths like/tmp/bzip2_overrideproduced wrong directory names)Test plan
"bundle_artifacts with overrides"testset passes in isolation (~2 min)Overrides.toml, confirmedOVERRIDE_MARKERpresent in bundled artifacts and accessible at runtime🤖 Generated with Claude Code