Skip to content

[yaml] - fix auto_sharding naming#3772

Open
derrickaw wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
derrickaw:20260507_fixAutosharding
Open

[yaml] - fix auto_sharding naming#3772
derrickaw wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
derrickaw:20260507_fixAutosharding

Conversation

@derrickaw
Copy link
Copy Markdown
Contributor

  1. Found an issue where our blueprints don't match the intended auto_sharding name.
  2. Yaml blueprint should have a key of auto_sharding and any java/jinja parameters should be autoSharding to match the similar naming patterns.
  3. IcebergToSQLServer blueprint is the model we are following.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 37.19%. Comparing base (09f9abc) to head (600ad14).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3772      +/-   ##
============================================
+ Coverage     33.47%   37.19%   +3.72%     
+ Complexity      482      471      -11     
============================================
  Files           215      194      -21     
  Lines         12891    11416    -1475     
  Branches       1262     1130     -132     
============================================
- Hits           4315     4246      -69     
+ Misses         8236     6832    -1404     
+ Partials        340      338       -2     
Components Coverage Δ
spanner-templates ∅ <ø> (∅)
spanner-import-export ∅ <ø> (∅)
spanner-live-forward-migration ∅ <ø> (∅)
spanner-live-reverse-replication ∅ <ø> (∅)
spanner-bulk-migration ∅ <ø> (∅)
gcs-spanner-dv ∅ <ø> (∅)
see 21 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@derrickaw derrickaw marked this pull request as ready for review May 7, 2026 19:26
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request standardizes the naming convention for the auto-sharding feature across the project's YAML blueprints and associated Java templates. By aligning the parameter names with existing patterns, the changes improve consistency and maintainability across the Iceberg-to-JDBC integration templates.

Highlights

  • Naming Standardization: Standardized the naming convention for auto-sharding parameters across all YAML blueprints, Java templates, and documentation to use 'autoSharding' for parameters and 'auto_sharding' for YAML keys.
  • Documentation Updates: Updated README files and command-line examples to reflect the new parameter naming scheme for consistency.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request standardizes the naming of the autosharding parameter by renaming it from autosharding to autoSharding across multiple files, including Java interfaces, YAML templates, Python options, and documentation. It also updates related environment variables to AUTO_SHARDING. I have no feedback to provide as there were no review comments.

@derrickaw derrickaw added yaml Pull requests that update Yaml code java Pull requests that update Java code labels May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug-fix java Pull requests that update Java code size/M yaml Pull requests that update Yaml code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant