[yaml] - fix auto_sharding naming#3772
[yaml] - fix auto_sharding naming#3772derrickaw wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3772 +/- ##
============================================
+ Coverage 33.47% 37.19% +3.72%
+ Complexity 482 471 -11
============================================
Files 215 194 -21
Lines 12891 11416 -1475
Branches 1262 1130 -132
============================================
- Hits 4315 4246 -69
+ Misses 8236 6832 -1404
+ Partials 340 338 -2
🚀 New features to boost your workflow:
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request standardizes the naming convention for the auto-sharding feature across the project's YAML blueprints and associated Java templates. By aligning the parameter names with existing patterns, the changes improve consistency and maintainability across the Iceberg-to-JDBC integration templates. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request standardizes the naming of the autosharding parameter by renaming it from autosharding to autoSharding across multiple files, including Java interfaces, YAML templates, Python options, and documentation. It also updates related environment variables to AUTO_SHARDING. I have no feedback to provide as there were no review comments.
auto_shardingand any java/jinja parameters should beautoShardingto match the similar naming patterns.