Skip to content

[SpannerToSourceDb] Increasing timeout in SpannerToMySqlCustomTransformationLT test#3770

Open
darshan-sj wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
darshan-sj:spanner-it
Open

[SpannerToSourceDb] Increasing timeout in SpannerToMySqlCustomTransformationLT test#3770
darshan-sj wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
darshan-sj:spanner-it

Conversation

@darshan-sj
Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the timeout configuration for the SpannerToMySqlCustomTransformationLT integration test. The adjustment is intended to provide more buffer time for the pipeline to complete, reducing flakiness in environments where execution might take longer than the previous 12-minute threshold.

Highlights

  • Test Timeout Adjustment: Increased the timeout duration for the reverseReplication1KTpsWithCustomTransformation test from 12 minutes to 18 minutes to prevent premature test failures.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request increases the timeout duration from 12 to 18 minutes in the reverseReplication1KTpsWithCustomTransformation load test to allow more time for the pipeline to meet the required conditions. I have no feedback to provide as there were no review comments to evaluate.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.30%. Comparing base (09f9abc) to head (2672518).

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #3770       +/-   ##
=============================================
+ Coverage     37.19%   53.30%   +16.11%     
- Complexity      471     6165     +5694     
=============================================
  Files           194     1079      +885     
  Lines         11416    65576    +54160     
  Branches       1130     7301     +6171     
=============================================
+ Hits           4246    34957    +30711     
- Misses         6832    28270    +21438     
- Partials        338     2349     +2011     
Components Coverage Δ
spanner-templates 72.83% <ø> (∅)
spanner-import-export 68.65% <ø> (∅)
spanner-live-forward-migration 80.94% <ø> (∅)
spanner-live-reverse-replication 77.06% <ø> (∅)
spanner-bulk-migration 91.11% <ø> (∅)
gcs-spanner-dv 85.76% <ø> (∅)
see 907 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant