Skip scanning internal index options from information schema#3767
Skip scanning internal index options from information schema#3767jason424217 wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a production issue where Import/Export operations failed when encountering vector indexes. By filtering out specific internal system index options from the information schema, the scanner can now successfully process these indexes without conflict. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the InformationSchemaScanner to filter out internal and system-optimized index options and introduces unit tests for this logic. Feedback highlights a bug where index names are not correctly qualified for GoogleSQL, which could lead to missing options for indexes in named schemas. It is also recommended to remove unused parameters and variables and to expand the test coverage to include named schemas.
jason424217
force-pushed
the
ziyue-dev
branch
2 times, most recently
from
7dd527f to
92737e1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3767 +/- ##
============================================
- Coverage 53.17% 53.16% -0.01%
+ Complexity 6499 6087 -412
============================================
Files 1075 1075
Lines 65263 65263
Branches 7239 7239
============================================
- Hits 34701 34697 -4
- Misses 28234 28238 +4
Partials 2328 2328
🚀 New features to boost your workflow:
|
|
Please add the #bug-fix label to this PR so the checks can pass. |
1 participant
Fix a production issue b/508672290 where Import/Export does not work with vector index now. Successfully export and import to https://pantheon.corp.google.com/spanner/instances/test-instance-nehadjoshi-prod/databases/ziyue-ann-gsql-imported/details/query?project=span-cloud-testing&chat= for gsql and https://pantheon.corp.google.com/spanner/instances/test-instance-nehadjoshi-prod/databases/ziyue-ann-pg-all/details/query?project=span-cloud-testing for pg that shows vector index with internal information schema indexes options.