Fix renderUsername type for strictFunctionTypes compatibility#2726
Open
dannyDotDev wants to merge 1 commit intoFaridSafi:masterfrom
Open
Fix renderUsername type for strictFunctionTypes compatibility#2726dannyDotDev wants to merge 1 commit intoFaridSafi:masterfrom
dannyDotDev wants to merge 1 commit intoFaridSafi:masterfrom
Conversation
The renderUsername prop was typed as (user?: TMessage['user']) => ReactNode but gets passed to renderComponentOrElement which expects (props: TProps) => ReactNode where TProps extends Record<string, any>. With strictFunctionTypes enabled (e.g. Expo's default tsconfig), the optional parameter creates a contravariance mismatch. The parameter is always called with currentMessage.user (never undefined), so making it required matches actual usage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
strictFunctionTypesis enabled (e.g. Expo's default tsconfig)renderUsernameprop inBubblePropsis typed as(user?: TMessage['user']) => ReactNode, but gets passed torenderComponentOrElementwhich expects(props: TProps) => ReactNodewhereTProps extends Record<string, any>The Error
At
src/Bubble/index.tsx:296:Fix
One-line change in
src/Bubble/types.ts:The parameter was already always called with
currentMessage.user(neverundefined), so making it required matches actual usage. This is similar to the fixes in #2698.Test
strictFunctionTypes: trueandstrictNullChecks: true