London | 26-SDC-MAR | Craig D'Silva | Sprint 5 | Prep#496
Open
craig-dsilva wants to merge 3 commits into
Open
Conversation
craig-dsilva
added
🏕 Priority Mandatory
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
May 13, 2026
Contributor
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work, can you review my 2 comments please
| self.preferred_operating_system = preferred_operating_system | ||
|
|
||
| def is_adult(self): | ||
| return self.age >= 18 |
Contributor
There was a problem hiding this comment.
Can you think of any conditions where this approach of pre-calculating the age in the constructor might cause problems?
| class Person: | ||
| name: str | ||
| age: dt.date | ||
| preferred_operating_system: str |
Contributor
There was a problem hiding this comment.
Can you add the is_adult method here and test that it still works?
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
This is the prep work for week 5.