Generate postgresql CRD from go structs (#3007)

* Sort postgresql.crd.yaml
* Generate postgresql CRD from go structs
* Expand sidecars, env and initcontainers
* Embed CRD to be submitted by the operator

Signed-off-by: Mikkel Oscar Lyderik Larsen <mikkel.larsen@zalando.de>

---------

Signed-off-by: Mikkel Oscar Lyderik Larsen <mikkel.larsen@zalando.de>

Author: mikkeloscar

.gitignore

@@ -106,3 +106,6 @@ mocks
 ui/.npm/
 
 .DS_Store
+
+# temp build files
+pkg/apis/acid.zalan.do/v1/postgresql.crd.yaml

Makefile

@@ -21,7 +21,7 @@ GITSTATUS = $(shell git status --porcelain || echo "no changes")
 SOURCES = cmd/main.go
 VERSION ?= $(shell git describe --tags --always --dirty)
 CRD_SOURCES    = $(shell find pkg/apis/zalando.org pkg/apis/acid.zalan.do -name '*.go' -not -name '*.deepcopy.go')
-GENERATED_CRDS = manifests/postgresteam.crd.yaml
+GENERATED_CRDS = manifests/postgresteam.crd.yaml manifests/postgresql.crd.yaml
 GENERATED      = pkg/apis/zalando.org/v1/zz_generated.deepcopy.go pkg/apis/acid.zalan.do/v1/zz_generated.deepcopy.go
 DIRS := cmd pkg
 PKG := `go list ./... | grep -v /vendor/`
@@ -54,6 +54,8 @@ default: local
 
 clean:
 	rm -rf build
+	rm $(GENERATED)
+	rm pkg/apis/acid.zalan.do/v1/postgresql.crd.yaml
 
 verify:
 	hack/verify-codegen.sh
@@ -63,10 +65,15 @@ $(GENERATED): go.mod $(CRD_SOURCES)
 
 $(GENERATED_CRDS): $(GENERATED)
 	go tool controller-gen crd:crdVersions=v1,allowDangerousTypes=true paths=./pkg/apis/acid.zalan.do/... output:crd:dir=manifests
-	# only generate postgresteam.crd.yaml for now
+	# only generate postgresteam.crd.yaml and postgresql.crd.yaml for now
 	@rm manifests/acid.zalan.do_operatorconfigurations.yaml
-	@rm manifests/acid.zalan.do_postgresqls.yaml
+	@mv manifests/acid.zalan.do_postgresqls.yaml manifests/postgresql.crd.yaml
+	@# hack to use lowercase kind and listKind
+	@sed -i -e 's/kind: Postgresql/kind: postgresql/' manifests/postgresql.crd.yaml
+	@sed -i -e 's/listKind: PostgresqlList/listKind: postgresqlList/' manifests/postgresql.crd.yaml
+	@hack/adjust_postgresql_crd.sh
 	@mv manifests/acid.zalan.do_postgresteams.yaml manifests/postgresteam.crd.yaml
+	@cp manifests/postgresql.crd.yaml pkg/apis/acid.zalan.do/v1/postgresql.crd.yaml
 
 local: ${SOURCES} $(GENERATED_CRDS)
 	CGO_ENABLED=${CGO_ENABLED} go build -o build/${BINARY} $(LOCAL_BUILD_FLAGS) -ldflags "$(LDFLAGS)" $(SOURCES)
@@ -98,7 +105,7 @@ vet:
 	@go vet $(PKG)
 	@staticcheck $(PKG)
 
-test: mocks $(GENERATED)
+test: mocks $(GENERATED) $(GENERATED_CRDS)
 	GO111MODULE=on go test ./...
 
 codegen: $(GENERATED)

hack/adjust_postgresql_crd.sh

@@ -0,0 +1,22 @@
+#!/usr/bin/env bash
+
+# Hack to adjust the generated postgresql CRD YAML file and add missing field
+# settings which can not be expressed via kubebuilder markers.
+#
+# Injections:
+#
+#  * oneOf: for the standby field to enforce that only one of s3_wal_path, gs_wal_path or standby_host is set.
+#    * This can later be done with // +kubebuilder:validation:ExactlyOneOf marker, but this requires latest Kubernetes version. (Currently the operator depends on v1.32.9)
+#  * type: string and pattern for the maintenanceWindows items.
+
+file="${1:-"manifests/postgresql.crd.yaml"}"
+
+sed -i '/^[[:space:]]*standby:$/{
+    # Capture the indentation
+    s/^\([[:space:]]*\)standby:$/\1standby:\n\1  oneOf:\n\1  - required:\n\1    - s3_wal_path\n\1  - required:\n\1    - gs_wal_path\n\1  - required:\n\1    - standby_host/
+}' "$file"
+
+sed -i '/^[[:space:]]*maintenanceWindows:$/{
+    # Capture the indentation
+    s/^\([[:space:]]*\)maintenanceWindows:$/\1maintenanceWindows:\n\1  items:\n\1    pattern: '\''^\\ *((Mon|Tue|Wed|Thu|Fri|Sat|Sun):(2[0-3]|[01]?\\d):([0-5]?\\d)|(2[0-3]|[01]?\\d):([0-5]?\\d))-((2[0-3]|[01]?\\d):([0-5]?\\d)|(2[0-3]|[01]?\\d):([0-5]?\\d))\\ *$'\''\n\1    type: string/
+}' "$file"