Skip to content

Commit f151999

Browse files
committed
SP int: fixes from AI review
Re-implemented wc_PKCS12_PBKDF() to not use MP. Added tests to unit.test. sp_int.c: Fixes to comments. Added more define build options documentation to top of file. Fixes for builds with WOLFSSL_SP_INT_NEGATIVE defined. Fixes for when a->used is 0 and no underflow - not actually a problem but cleaner code. sp_sub has different checks on a->used when values are only positive. sp_dic_2d missing check for e less than zero. sp_to_unsigned_bin_len_ct: remove redundant check of outSz. Change i to int to handle a->used of 0 and make code tidier. Configuration testing fixes. Fix formatting in test.c. Added 128-bit types word128 and sword128 for cleaner PKCS#12 code.
1 parent 20f640a commit f151999

13 files changed

Lines changed: 957 additions & 245 deletions

File tree

.wolfssl_known_macro_extras

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -644,6 +644,7 @@ WC_NO_RNG_SIMPLE
644644
WC_NO_STATIC_ASSERT
645645
WC_NO_VERBOSE_RNG
646646
WC_PKCS11_FIND_WITH_ID_ONLY
647+
WC_PKCS12_PBKDF_USING_MP_API
647648
WC_PROTECT_ENCRYPTED_MEM
648649
WC_RNG_BLOCKING
649650
WC_RSA_NONBLOCK

tests/api.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23560,7 +23560,7 @@ static int test_wolfSSL_X509_print(void)
2356023560
{
2356123561
EXPECT_DECLS;
2356223562
#if defined(OPENSSL_EXTRA) && !defined(NO_FILESYSTEM) && \
23563-
!defined(NO_RSA) && defined(XSNPRINTF)
23563+
!defined(NO_RSA) && defined(XSNPRINTF) && !defined(WC_DISABLE_RADIX_ZERO_PAD)
2356423564
X509 *x509 = NULL;
2356523565
BIO *bio = NULL;
2356623566
#if defined(OPENSSL_ALL) && !defined(NO_WOLFSSL_DIR)

0 commit comments

Comments
 (0)