Skip to content

Commit ebdcc03

Browse files
Code review feedback
1 parent 1397268 commit ebdcc03

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

wolfcrypt/src/pkcs7.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2256,7 +2256,7 @@ static int wc_PKCS7_BuildSignedAttributes(wc_PKCS7* pkcs7, ESD* esd,
22562256
esd->signedAttribsCount += idx;
22572257
esd->signedAttribsSz += (word32)EncodeAttributes(
22582258
&esd->signedAttribs[atrIdx], (int)idx, cannedAttribs,
2259-
(int)cannedAttribsCount);
2259+
(int)idx);
22602260
atrIdx += idx;
22612261
} else {
22622262
esd->signedAttribsCount = 0;
@@ -13242,7 +13242,9 @@ int wc_PKCS7_DecodeEnvelopedData(wc_PKCS7* pkcs7, byte* in,
1324213242
}
1324313243
wc_PKCS7_DecryptContentFree(pkcs7, encOID, pkcs7->heap);
1324413244
} else {
13245-
if ((idx + (word32)encryptedContentTotalSz) > pkiMsgSz) {
13245+
word32 tmpSum;
13246+
if (!WC_SAFE_SUM_WORD32(idx, (word32)encryptedContentTotalSz, tmpSum) ||
13247+
tmpSum > pkiMsgSz) {
1324613248
ret = BUFFER_E;
1324713249
break;
1324813250
}

0 commit comments

Comments
 (0)