Fix from review

embhorn · embhorn · commit 935c3901d9f5 · 2026-05-07T07:34:39.000-05:00
diff --git a/wolfcrypt/src/dilithium.c b/wolfcrypt/src/dilithium.c
@@ -8333,13 +8333,13 @@ static int dilithium_sign_with_seed_mu(dilithium_key* key,
 #ifdef WC_DILITHIUM_CACHE_MATRIX_A
 #ifndef WC_DILITHIUM_FIXED_ARRAY
     if ((ret == 0) && (key->a == NULL)) {
-        key->a = (sword32*)XMALLOC(params->aSz, key->heap,
+        key->a = (sword32*)XMALLOC((size_t)params->aSz, key->heap,
             DYNAMIC_TYPE_DILITHIUM);
         if (key->a == NULL) {
             ret = MEMORY_E;
         }
         else {
-            XMEMSET(key->a, 0, params->aSz);
+            XMEMSET(key->a, 0, (size_t)params->aSz);
         }
     }
 #endif

Original file line number	Diff line number	Diff line change
`@@ -8333,13 +8333,13 @@ static int dilithium_sign_with_seed_mu(dilithium_key* key,`
`8333`	`8333`	`#ifdef WC_DILITHIUM_CACHE_MATRIX_A`
`8334`	`8334`	`#ifndef WC_DILITHIUM_FIXED_ARRAY`
`8335`	`8335`	`if ((ret == 0) && (key->a == NULL)) {`
`8336`		`- key->a = (sword32*)XMALLOC(params->aSz, key->heap,`
	`8336`	`+ key->a = (sword32*)XMALLOC((size_t)params->aSz, key->heap,`
`8337`	`8337`	`DYNAMIC_TYPE_DILITHIUM);`
`8338`	`8338`	`if (key->a == NULL) {`
`8339`	`8339`	`ret = MEMORY_E;`
`8340`	`8340`	`}`
`8341`	`8341`	`else {`
`8342`		`- XMEMSET(key->a, 0, params->aSz);`
	`8342`	`+ XMEMSET(key->a, 0, (size_t)params->aSz);`
`8343`	`8343`	`}`
`8344`	`8344`	`}`
`8345`	`8345`	`#endif`