Fix from review

embhorn · embhorn · commit 10c2ada0002f · 2026-05-06T12:07:41.000-05:00
diff --git a/wolfcrypt/src/dilithium.c b/wolfcrypt/src/dilithium.c
@@ -8318,13 +8318,13 @@ static int dilithium_sign_with_seed_mu(dilithium_key* key,
 #ifdef WC_DILITHIUM_CACHE_MATRIX_A
 #ifndef WC_DILITHIUM_FIXED_ARRAY
     if ((ret == 0) && (key->a == NULL)) {
-        key->a = (sword32*)XMALLOC(params->aSz, key->heap,
+        key->a = (sword32*)XMALLOC((size_t)params->aSz, key->heap,
             DYNAMIC_TYPE_DILITHIUM);
         if (key->a == NULL) {
             ret = MEMORY_E;
         }
         else {
-            XMEMSET(key->a, 0, params->aSz);
+            XMEMSET(key->a, 0, (size_t)params->aSz);
         }
     }
 #endif

Original file line number	Diff line number	Diff line change
`@@ -8318,13 +8318,13 @@ static int dilithium_sign_with_seed_mu(dilithium_key* key,`
`8318`	`8318`	`#ifdef WC_DILITHIUM_CACHE_MATRIX_A`
`8319`	`8319`	`#ifndef WC_DILITHIUM_FIXED_ARRAY`
`8320`	`8320`	`if ((ret == 0) && (key->a == NULL)) {`
`8321`		`- key->a = (sword32*)XMALLOC(params->aSz, key->heap,`
	`8321`	`+ key->a = (sword32*)XMALLOC((size_t)params->aSz, key->heap,`
`8322`	`8322`	`DYNAMIC_TYPE_DILITHIUM);`
`8323`	`8323`	`if (key->a == NULL) {`
`8324`	`8324`	`ret = MEMORY_E;`
`8325`	`8325`	`}`
`8326`	`8326`	`else {`
`8327`		`- XMEMSET(key->a, 0, params->aSz);`
	`8327`	`+ XMEMSET(key->a, 0, (size_t)params->aSz);`
`8328`	`8328`	`}`
`8329`	`8329`	`}`
`8330`	`8330`	`#endif`