Skip to content

Commit d070784

Browse files
author
ivan-skryabin
committed
fix grpc: DP in unary calls
commit_hash:5d5e097f61771bcaa69a81c450cc32d64b37b6d5
1 parent e511e52 commit d070784

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

grpc/include/userver/ugrpc/client/impl/unary_call.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ class UnaryCall final {
145145
}
146146

147147
if (impl::IsTaskCancelledByDeadlinePropagation()) {
148-
utils::unexpected{SpecialCaseCompletionType::kTimeoutDeadlinePropagated};
148+
return utils::unexpected{SpecialCaseCompletionType::kTimeoutDeadlinePropagated};
149149
}
150150

151151
return utils::unexpected{SpecialCaseCompletionType::kCancelled};
@@ -185,7 +185,7 @@ class UnaryCall final {
185185

186186
case ugrpc::impl::AsyncMethodInvocation::WaitStatus::kCancelled:
187187
if (impl::IsTaskCancelledByDeadlinePropagation()) {
188-
utils::unexpected{SpecialCaseCompletionType::kTimeoutDeadlinePropagated};
188+
return utils::unexpected{SpecialCaseCompletionType::kTimeoutDeadlinePropagated};
189189
}
190190
return utils::unexpected{SpecialCaseCompletionType::kCancelled};
191191

universal/include/userver/utils/expected.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ class bad_expected_access : public std::exception {
3030
};
3131

3232
template <class E>
33-
class unexpected {
33+
class [[nodiscard]] unexpected {
3434
public:
3535
unexpected(const E& error);
3636
unexpected(E&& error);

0 commit comments

Comments
 (0)