feat universal: cleanup logging helpers

Tests: протестировано CI
commit_hash:557e0f764c1c49bfe9437acd0963cb34508ffe0e

Author: apolukhin

core/src/tracing/span.cpp

@@ -197,7 +197,7 @@ void Span::Impl::PutIntoLogger(logging::impl::TagWriter writer) && {
 }
 
 void Span::Impl::LogTo(logging::impl::TagWriter writer) const {
-    writer.ExtendLogExtra(log_extra_inheritable_);
+    writer.PutLogExtra(log_extra_inheritable_);
 
     if (const auto span_id = GetSpanIdForChildLogs()) {
         writer.PutTag(kTraceIdTag, GetTraceId());

universal/include/userver/logging/impl/tag_writer.hpp

@@ -50,20 +50,11 @@ class TagWriter {
     // The tags must not be duplicated in other Put* calls.
     void PutLogExtra(const LogExtra& extra);
 
-    // Copies the tags to the internal LogExtra. They will be deduplicated
-    // automatically.
-    void ExtendLogExtra(const LogExtra& extra);
-
 private:
     friend class logging::LogHelper;
 
     explicit TagWriter(LogHelper& lh) noexcept;
 
-    void PutKey(TagKey key);
-    void PutKey(RuntimeTagKey key);
-
-    void MarkValueEnd() noexcept;
-
     LogHelper& lh_;
 };
 
@@ -91,12 +82,20 @@ consteval TagKey::TagKey(const StringType& escaped_key)
 
 template <typename T>
 void TagWriter::PutTag(TagKey key, const T& value) {
-    lh_.PutTag(key.GetEscapedKey(), value);
+    if constexpr (std::is_convertible_v<T, std::string_view>) {
+        lh_.PutSwTag(key.GetEscapedKey(), value);
+    } else {
+        lh_.PutTag(key.GetEscapedKey(), value);
+    }
 }
 
 template <typename T>
 void TagWriter::PutTag(RuntimeTagKey key, const T& value) {
-    lh_.PutTag(key.GetUnescapedKey(), std::variant{value});
+    if constexpr (std::is_convertible_v<T, std::string_view>) {
+        lh_.PutSwTag(key.GetUnescapedKey(), value);
+    } else {
+        lh_.PutTag(key.GetUnescapedKey(), value);
+    }
 }
 
 }  // namespace logging::impl

universal/src/logging/impl/tag_writer.cpp

@@ -37,12 +37,6 @@ void TagWriter::PutLogExtra(const LogExtra& extra) {
     }
 }
 
-void TagWriter::ExtendLogExtra(const LogExtra& extra) {
-    for (const auto& item : *extra.extra_) {
-        PutTag(RuntimeTagKey{item.first}, item.second.GetValue());
-    }
-}
-
 void TagWriter::PutTag(RuntimeTagKey key, std::string_view value) { lh_.PutSwTag(key.GetUnescapedKey(), value); }
 
 TagWriter::TagWriter(LogHelper& lh) noexcept : lh_(lh) {}