server: disable always on http auth for docker (#1089)

Author: LucioFranco

docker-entrypoint.sh

@@ -7,8 +7,6 @@ SQLD_NODE="${SQLD_NODE:-primary}"
 SQLD_DB_PATH="${SQLD_DB_PATH:-iku.db}"
 SQLD_HTTP_LISTEN_ADDR="${SQLD_HTTP_LISTEN_ADDR:-"0.0.0.0:8080"}"
 
-SQLD_HTTP_AUTH="${SQLD_HTTP_AUTH:-"always"}"
-
 if [ "$1" = '/bin/sqld' ]; then
   # We are running the server.
   declare -a server_args=()

libsql-server/src/auth/parsers.rs

@@ -6,7 +6,7 @@ use tonic::metadata::MetadataMap;
 
 pub fn parse_http_basic_auth_arg(arg: &str) -> Result<Option<String>> {
     if arg == "always" {
-        return Ok(None);
+        return Ok(Some("always".to_string()));
     }
 
     let Some((scheme, param)) = arg.split_once(':') else {
@@ -71,6 +71,8 @@ mod tests {
 
     use crate::auth::{parse_http_auth_header, AuthError};
 
+    use super::parse_http_basic_auth_arg;
+
     #[test]
     fn parse_http_auth_header_returns_auth_header_param_when_valid() {
         assert_eq!(
@@ -111,4 +113,10 @@ mod tests {
             AuthError::HttpAuthHeaderUnsupportedScheme
         )
     }
+
+    #[test]
+    fn parse_http_auth_arg_always() {
+        let out = parse_http_basic_auth_arg("always").unwrap();
+        assert_eq!(out, Some("always".to_string()));
+    }
 }