libsql: Make Statement::query() immutable

Author: penberg

libsql/src/connection.rs

@@ -170,7 +170,7 @@ impl Connection {
     /// For more info on how to pass params check [`IntoParams`]'s docs and on how to
     /// extract values out of the rows check the [`Rows`] docs.
     pub async fn query(&self, sql: &str, params: impl IntoParams) -> Result<Rows> {
-        let mut stmt = self.prepare(sql).await?;
+        let stmt = self.prepare(sql).await?;
 
         stmt.query(params).await
     }

libsql/src/hrana/hyper.rs

@@ -241,7 +241,7 @@ impl crate::statement::Stmt for crate::hrana::Statement<HttpSender> {
         self.execute(params).await
     }
 
-    async fn query(&mut self, params: &Params) -> crate::Result<Rows> {
+    async fn query(&self, params: &Params) -> crate::Result<Rows> {
         self.query(params).await
     }
 

libsql/src/hrana/mod.rs

@@ -179,7 +179,7 @@ where
     }
 
     pub(crate) async fn query_raw(
-        &mut self,
+        &self,
         params: &Params,
     ) -> crate::Result<HranaRows<T::Stream, T>> {
         let mut stmt = self.inner.clone();
@@ -197,7 +197,7 @@ where
     T: HttpSend + Send + Sync + 'static,
     <T as HttpSend>::Stream: Send + Sync + 'static,
 {
-    pub async fn query(&mut self, params: &Params) -> crate::Result<super::Rows> {
+    pub async fn query(&self, params: &Params) -> crate::Result<super::Rows> {
         let rows = self.query_raw(params).await?;
         Ok(super::Rows::new(rows))
     }

libsql/src/local/impls.rs

@@ -115,7 +115,7 @@ impl Stmt for LibsqlStmt {
         stmt.execute(&params).map(|i| i as usize)
     }
 
-    async fn query(&mut self, params: &Params) -> Result<Rows> {
+    async fn query(&self, params: &Params) -> Result<Rows> {
         let params = params.clone();
         let stmt = self.0.clone();
 

libsql/src/replication/connection.rs

@@ -688,8 +688,8 @@ impl Stmt for RemoteStatement {
         Ok(affected_row_count as usize)
     }
 
-    async fn query(&mut self, params: &Params) -> Result<Rows> {
-        if let Some(stmt) = &mut self.local_statement {
+    async fn query(&self, params: &Params) -> Result<Rows> {
+        if let Some(stmt) = &self.local_statement {
             return stmt.query(params.clone()).await;
         }
 

libsql/src/statement.rs

@@ -10,7 +10,7 @@ pub(crate) trait Stmt {
 
     async fn execute(&mut self, params: &Params) -> Result<usize>;
 
-    async fn query(&mut self, params: &Params) -> Result<Rows>;
+    async fn query(&self, params: &Params) -> Result<Rows>;
 
     async fn run(&mut self, params: &Params) -> Result<()>;
 
@@ -45,7 +45,7 @@ impl Statement {
     }
 
     /// Execute a query on the statement, check [`Connection::query`] for usage.
-    pub async fn query(&mut self, params: impl IntoParams) -> Result<Rows> {
+    pub async fn query(&self, params: impl IntoParams) -> Result<Rows> {
         tracing::trace!("query for prepared statement");
         self.inner.query(&params.into_params()?).await
     }

libsql/src/sync/statement.rs

@@ -29,7 +29,7 @@ impl Stmt for SyncedStatement {
         self.inner.execute(params).await
     }
 
-    async fn query(&mut self, params: &Params) -> Result<Rows> {
+    async fn query(&self, params: &Params) -> Result<Rows> {
         if self.needs_pull.load(Ordering::Relaxed) {
             let mut context = self.context.lock().await;
             crate::sync::try_pull(&mut context, &self.conn).await?;