fixed panic on OOB access - returned error instead

adhi-thirumala · adhi-thirumala · commit 11f4ee0a071d · 2025-12-25T23:51:04.000-05:00
diff --git a/libsql/src/hrana/mod.rs b/libsql/src/hrana/mod.rs
@@ -326,7 +326,7 @@ impl Row {
 
 impl RowInner for Row {
     fn column_value(&self, idx: i32) -> crate::Result<crate::Value> {
-        let v = self.inner.get(idx as usize).cloned().unwrap();
+        let v = self.inner.get(idx as usize).cloned().ok_or_else(|| crate::Error::InvalidColumnIndex(idx))?;
         Ok(into_value2(v))
     }
 

Original file line number	Diff line number	Diff line change
`@@ -326,7 +326,7 @@ impl Row {`
`326`	`326`
`327`	`327`	`impl RowInner for Row {`
`328`	`328`	`fn column_value(&self, idx: i32) -> crate::Result<crate::Value> {`
`329`		`- let v = self.inner.get(idx as usize).cloned().unwrap();`
	`329`	`+ let v = self.inner.get(idx as usize).cloned().ok_or_else(\|\| crate::Error::InvalidColumnIndex(idx))?;`
`330`	`330`	`Ok(into_value2(v))`
`331`	`331`	`}`
`332`	`332`