FIXES

Author: penberg

index.d.ts

@@ -9,6 +9,7 @@ export interface Options {
   syncUrl?: string
   syncPeriod?: number
 }
+export declare function databaseSyncSync(db: Database): SyncResult
 export declare function databasePrepareSync(db: Database, sql: string): Statement
 export interface RunResult {
   changes: number
@@ -44,8 +45,7 @@ export declare class Database {
   close(): void
   defaultSafeIntegers(toggle?: boolean | undefined | null): void
   unsafeMode(): void
-  sync(): SyncResult
-  syncUntil(replicationIndex: number): SyncResult
+  sync(): Promise<SyncResult>
 }
 export declare class Statement {
   columns(): unknown[]

index.js

@@ -310,10 +310,11 @@ if (!nativeBinding) {
   throw new Error(`Failed to load native binding`)
 }
 
-const { SqliteError, Database, databasePrepareSync, Statement, RowsIterator, iteratorNextSync, Record } = nativeBinding
+const { SqliteError, Database, databaseSyncSync, databasePrepareSync, Statement, RowsIterator, iteratorNextSync, Record } = nativeBinding
 
 module.exports.SqliteError = SqliteError
 module.exports.Database = Database
+module.exports.databaseSyncSync = databaseSyncSync
 module.exports.databasePrepareSync = databasePrepareSync
 module.exports.Statement = Statement
 module.exports.RowsIterator = RowsIterator

promise.js

@@ -52,7 +52,11 @@ class Database {
   }
 
   sync() {
-    throw new Error("not implemented");
+    try {
+      return this.db.sync();
+    } catch (err) {
+      throw convertError(err);
+    }
   }
 
   syncUntil(replicationIndex) {

src/lib.rs

@@ -433,28 +433,19 @@ impl Database {
     }
 
     #[napi]
-    pub fn sync(&self) -> Result<SyncResult> {
-        let rt = runtime()?;
-        let result = rt.block_on(async move {
-            self.db.sync().await.map_err(Error::from)
-        })?;
+    pub async fn sync(&self) -> Result<SyncResult> {
+        let result = self.db.sync().await.map_err(Error::from)?;
         Ok(SyncResult {
             frames_synced: result.frames_synced() as f64,
             replication_index: result.frame_no().unwrap_or(0) as f64,
         })
     }
+}
 
-    #[napi]
-    pub fn syncUntil(&self, replication_index: f64) -> Result<SyncResult> {
-        let rt = runtime()?;
-        let result = rt.block_on(async move {
-            self.db.sync_until(replication_index as u64).await.map_err(Error::from)
-        })?;
-        Ok(SyncResult {
-            frames_synced: result.frames_synced() as f64,
-            replication_index: result.frame_no().unwrap_or(0) as f64,
-        })
-    }
+#[napi]
+pub fn database_sync_sync(db: &Database) -> Result<SyncResult> {
+    let rt = runtime()?;
+    rt.block_on(async move { db.sync().await })
 }
 
 fn is_remote_path(path: &str) -> bool {

wrapper.js

@@ -1,6 +1,6 @@
 "use strict";
 
-const { Database: NativeDb, databasePrepareSync, iteratorNextSync } = require("./index.js");
+const { Database: NativeDb, databasePrepareSync, databaseSyncSync, iteratorNextSync } = require("./index.js");
 const SqliteError = require("./sqlite-error.js");
 const Authorization = require("./auth");
 
@@ -53,7 +53,7 @@ class Database {
 
   sync() {
     try {
-      const result = this.db.sync();
+      const result = databaseSyncSync(this.db);
       return {
         frames_synced: result.frames_synced,
         replication_index: result.replication_index
@@ -64,15 +64,7 @@ class Database {
   }
 
   syncUntil(replicationIndex) {
-    try {
-      const result = this.db.syncUntil(replicationIndex);
-      return {
-        frames_synced: result.frames_synced,
-        replication_index: result.replication_index
-      };
-    } catch (err) {
-      throw convertError(err);
-    }
+    throw new Error("not implemented");
   }
 
   /**