hacks

Author: penberg

index.d.ts

@@ -53,9 +53,9 @@ export declare class Statement {
   get(params?: unknown | undefined | null): unknown
   iterate(params?: unknown | undefined | null): object
   iterateSync(params?: unknown | undefined | null): RowsIterator
-  pluck(pluck?: boolean | undefined | null): this
   raw(raw?: boolean | undefined | null): this
-  timed(timed?: boolean | undefined | null): this
+  pluck(pluck?: boolean | undefined | null): this
+  timing(timed?: boolean | undefined | null): this
   columns(): unknown[]
   safeIntegers(toggle?: boolean | undefined | null): this
   interrupt(): void

integration-tests/tests/extensions.test.js

@@ -5,7 +5,7 @@ test.serial("Statement.run() returning duration", async (t) => {
   const db = t.context.db;
 
   const stmt = db.prepare("SELECT 1");
-  const info = stmt.run();
+  const info = stmt.timing().run();
   t.not(info.duration, undefined);
   t.log(info.duration)
 });
@@ -14,7 +14,7 @@ test.serial("Statement.get() returning duration", async (t) => {
   const db = t.context.db;
 
   const stmt = db.prepare("SELECT ?");
-  const info = stmt.get(1);
+  const info = stmt.timing().get(1);
   t.not(info._metadata?.duration, undefined);
   t.log(info._metadata?.duration)
 });

src/lib.rs

@@ -1102,14 +1102,11 @@ fn map_row_raw(
 ) -> Result<napi::JsUnknown> {
     let column_count = column_names.len();
     let mut js_array = env.create_array(column_count as u32)?;
-
-    for (idx, _col_name) in column_names.iter().enumerate().take(column_count) {
+    for idx in 0..column_count {
         let value = match row.get_value(idx as i32) {
             Ok(v) => v,
             Err(e) => return Err(napi::Error::from_reason(e.to_string())),
         };
-
-        // Create appropriate JS value based on SQLite value type
         let js_value = match value {
             libsql::Value::Null => env.get_null()?.into_unknown(),
             libsql::Value::Integer(v) => {
@@ -1125,7 +1122,6 @@ fn map_row_raw(
         };
         js_array.set(idx as u32, js_value)?;
     }
-
     if pluck {
         let result = match js_array.get::<JsUnknown>(0)? {
             Some(value) => value.into_unknown(),