PERF

Author: penberg

src/lib.rs

@@ -15,6 +15,7 @@ use std::sync::Arc;
 use std::time::Duration;
 use tokio::{runtime::Runtime, sync::Mutex};
 use tracing_subscriber::{filter::LevelFilter, EnvFilter};
+use tracing::trace;
 
 #[napi]
 pub struct SqliteError {
@@ -575,6 +576,7 @@ impl Statement {
 
     #[napi]
     pub fn iterate(&self, env: Env, params: Option<napi::JsUnknown>) -> Result<napi::JsObject> {
+        trace!("Statement::iterate");
         let rt = runtime()?;
         let safe_ints = self.safe_ints.load(Ordering::SeqCst);
         let raw = self.raw.load(Ordering::SeqCst);
@@ -601,8 +603,9 @@ impl Statement {
             let mut column_names = vec![];
             for i in 0..result.column_count() {
                 let column_name = result.column_name(i).unwrap();
-                let column_name = env.create_string(column_name)?;
-                let column_name = env.create_reference(column_name)?;
+                let column_name = env.create_string(column_name).unwrap();
+                let column_name = column_name.coerce_to_object().unwrap();
+                let column_name = env.create_reference(column_name).unwrap();
                 column_names.push(column_name);
             }
             let iter = RowsIterator::new(
@@ -638,8 +641,9 @@ impl Statement {
             let mut column_names = vec![];  
             for i in 0..rows.column_count() {
                 let column_name = rows.column_name(i).unwrap();
-                let column_name = env.create_string(column_name)?;
-                let column_name = env.create_reference(column_name)?;
+                let column_name = env.create_string(column_name).unwrap();
+                let column_name = column_name.coerce_to_object().unwrap();
+                let column_name = env.create_reference(column_name).unwrap();
                 column_names.push(column_name);
             }
             Ok::<_, napi::Error>((rows, column_names))
@@ -732,8 +736,9 @@ impl Statement {
             let mut column_names = vec![];
             for i in 0..rows.column_count() {
                 let column_name = rows.column_name(i).unwrap();
-                let column_name = env.create_string(column_name)?;
-                let column_name = env.create_reference(column_name)?;
+                let column_name = env.create_string(column_name).unwrap();
+                let column_name = column_name.coerce_to_object().unwrap();
+                let column_name = env.create_reference(column_name).unwrap();
                 column_names.push(column_name);
             }
             let column_names = Arc::new(column_names);
@@ -813,6 +818,7 @@ impl RowsIterator {
 
     #[napi]
     pub fn next(&self, env: Env) -> Result<Record> {
+        trace!("RowsIterator::next");
         let rt = runtime()?;
         let rows = self.rows.clone();
         rt.block_on(async move {
@@ -935,7 +941,7 @@ fn map_row_object(
                 Ok(v) => v,
                 Err(e) => return Err(napi::Error::from_reason(e.to_string())),
             };
-            let column_name: JsString = env.get_reference_value(&column_names[idx])?;
+            let column_name: napi::JsObject = env.get_reference_value(&column_names[idx])?;
             let js_value = convert_value_to_js(env, &value, safe_ints)?;
             result.set_property(column_name, js_value)?;
         }