fix: group header rendering error related to date field (#1066)

* fix: duplicate record cannot be undo

* fix: group header rendering error related to date field

Author: Sky-FE

apps/nestjs-backend/src/features/record/open-api/record-open-api.controller.ts

@@ -143,6 +143,7 @@ export class RecordOpenApiController {
 
   @Permissions('record|create')
   @Post(':recordId')
+  @EmitControllerEvent(Events.OPERATION_RECORDS_CREATE)
   async duplicateRecord(
     @Param('tableId') tableId: string,
     @Param('recordId') recordId: string,

apps/nestjs-backend/src/features/record/open-api/record-open-api.service.ts

@@ -582,9 +582,6 @@ export class RecordOpenApiService {
       order,
       records: [records],
     };
-    const createdRecords = await this.prismaService.$tx(async () =>
-      this.createRecords(tableId, createRecordsRo)
-    );
-    return { id: createdRecords.records[0]?.id };
+    return await this.prismaService.$tx(async () => this.createRecords(tableId, createRecordsRo));
   }
 }

apps/nestjs-backend/test/record.e2e-spec.ts

@@ -303,7 +303,7 @@ describe('OpenAPI RecordController (e2e)', () => {
         anchorId: addRecord.id,
         position: 'after',
       });
-      const record = await getRecord(table.id, duplicateRes.id, undefined, 200);
+      const record = await getRecord(table.id, duplicateRes.records[0].id, undefined, 200);
       expect(record.fields[table.fields[0].id]).toEqual(value1);
     });
   });

apps/nestjs-backend/test/utils/init-app.ts

@@ -26,7 +26,6 @@ import type {
   ITableFullVo,
   ICreateSpaceRo,
   ICreateBaseRo,
-  IDuplicateVo,
   IRecordInsertOrderRo,
 } from '@teable/openapi';
 import {
@@ -332,7 +331,7 @@ export async function duplicateRecord(
     if ((e as HttpError).status !== expectStatus) {
       throw e;
     }
-    return {} as IDuplicateVo;
+    return {} as ICreateRecordsVo;
   }
 }
 

packages/core/src/models/field/cell-value-validation.ts

@@ -61,3 +61,10 @@ export const validateCellValue = (field: IFieldVo, cellValue: unknown) => {
       assertNever(type);
   }
 };
+
+export const validateDateFieldValueLoose = (cellValue: unknown, isMultipleCellValue?: boolean) => {
+  if (isMultipleCellValue) {
+    return z.array(z.string()).nonempty().nullable().safeParse(cellValue);
+  }
+  return z.string().nullable().safeParse(cellValue);
+};

packages/openapi/src/record/duplicate.ts

@@ -1,16 +1,11 @@
 import { axios } from '../axios';
 import { registerRoute, urlBuilder } from '../utils';
 import { z } from '../zod';
-import type { IRecordInsertOrderRo } from './create';
-import { recordInsertOrderRoSchema } from './create';
+import type { ICreateRecordsVo, IRecordInsertOrderRo } from './create';
+import { createRecordsVoSchema, recordInsertOrderRoSchema } from './create';
 
 export const DUPLICATE_URL = '/table/{tableId}/record/{recordId}';
 
-export const duplicateVoSchema = z.object({
-  id: z.string(),
-});
-
-export type IDuplicateVo = z.infer<typeof duplicateVoSchema>;
 export const duplicateRoute = registerRoute({
   method: 'post',
   path: DUPLICATE_URL,
@@ -33,7 +28,7 @@ export const duplicateRoute = registerRoute({
       description: 'Successful duplicate',
       content: {
         'application/json': {
-          schema: duplicateVoSchema,
+          schema: createRecordsVoSchema,
         },
       },
     },
@@ -46,5 +41,5 @@ export const duplicateRecord = async (
   recordId: string,
   order: IRecordInsertOrderRo
 ) => {
-  return axios.post<IDuplicateVo>(urlBuilder(DUPLICATE_URL, { tableId, recordId }), order);
+  return axios.post<ICreateRecordsVo>(urlBuilder(DUPLICATE_URL, { tableId, recordId }), order);
 };

packages/sdk/src/components/grid-enhancements/hooks/use-grid-group-collection.ts

@@ -1,10 +1,10 @@
 import type { IAttachmentCellValue, INumberShowAs, ISingleLineTextShowAs } from '@teable/core';
-import { CellValueType, ColorUtils, FieldType } from '@teable/core';
+import { CellValueType, ColorUtils, FieldType, validateDateFieldValueLoose } from '@teable/core';
 import { LRUCache } from 'lru-cache';
 import { useCallback, useMemo } from 'react';
 import { useTranslation } from '../../../context/app/i18n/useTranslation';
 import { useFields, useView } from '../../../hooks';
-import type { DateField, IFieldInstance } from '../../../model';
+import type { IFieldInstance } from '../../../model';
 import { getFileCover, isSystemFileIcon } from '../../editor';
 import { GRID_DEFAULT } from '../../grid/configs';
 import type { IGridColumn } from '../../grid/interface';
@@ -53,7 +53,7 @@ const useGenerateGroupCellFn = () => {
 
         const validateCellValue =
           field.cellValueType === CellValueType.DateTime
-            ? (field as DateField).validateCellValueLoose(_cellValue)
+            ? validateDateFieldValueLoose(_cellValue)
             : field.validateCellValue(_cellValue);
         const cellValue = (
           validateCellValue.success ? validateCellValue.data : undefined