Skip to content

Commit 7f8a169

Browse files
authored
fix: records cannot be deleted using the record menu (#1109)
1 parent 9a8402a commit 7f8a169

3 files changed

Lines changed: 6 additions & 7 deletions

File tree

apps/nextjs-app/src/features/app/blocks/view/grid/GridViewBaseInner.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,7 @@ export const GridViewBaseInner: React.FC<IGridViewBaseInnerProps> = (
305305
openRecordMenu({
306306
position,
307307
isMultipleSelected,
308-
deleteRecords: async (selection) => {
308+
deleteRecords: async () => {
309309
deleteRecords(selection);
310310
gridRef.current?.setSelection(emptySelection);
311311
},
@@ -341,7 +341,7 @@ export const GridViewBaseInner: React.FC<IGridViewBaseInnerProps> = (
341341
position: 'after',
342342
});
343343
},
344-
deleteRecords: async (selection) => {
344+
deleteRecords: async () => {
345345
deleteRecords(selection);
346346
gridRef.current?.setSelection(emptySelection);
347347
},

apps/nextjs-app/src/features/app/blocks/view/grid/components/RecordMenu.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ const InsertRecordRender = (props: InsertRecordRender) => {
106106
};
107107

108108
export const RecordMenu = () => {
109-
const { recordMenu, closeRecordMenu, selection } = useGridViewStore();
109+
const { recordMenu, closeRecordMenu } = useGridViewStore();
110110
const { t } = useTranslation(tableConfig.i18nNamespaces);
111111
const tableId = useTableId();
112112
const view = useView();
@@ -206,8 +206,8 @@ export const RecordMenu = () => {
206206
hidden: !permission['record|delete'],
207207
className: 'text-red-500 aria-selected:text-red-500',
208208
onClick: async () => {
209-
if (recordMenu && tableId && recordMenu.deleteRecords && selection) {
210-
await recordMenu.deleteRecords(selection);
209+
if (recordMenu && tableId && recordMenu.deleteRecords) {
210+
await recordMenu.deleteRecords();
211211
}
212212
},
213213
},

packages/sdk/src/components/grid-enhancements/store/type.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import type { IFieldInstance, Record } from '../../../model';
22
import type { IPosition, IRectangle } from '../../grid/interface';
3-
import type { CombinedSelection } from '../../grid/managers';
43

54
export interface IHeaderMenu {
65
fields: IFieldInstance[];
@@ -14,7 +13,7 @@ export interface IRecordMenu {
1413
neighborRecords?: (Record | null)[];
1514
isMultipleSelected?: boolean;
1615
position: IPosition;
17-
deleteRecords?: (selection: CombinedSelection) => Promise<void>;
16+
deleteRecords?: () => Promise<void>;
1817
insertRecord?: (anchorId: string, position: 'before' | 'after', num: number) => void;
1918
duplicateRecord?: () => Promise<void>;
2019
}

0 commit comments

Comments
 (0)