fix: link fix logic error (#1445)

Author: tea-artist

apps/nestjs-backend/src/features/integrity/foreign-key.service.ts

@@ -93,9 +93,9 @@ export class ForeignKeyIntegrityService {
         const message = isSelfReference
           ? `Found ${refCount} invalid self references in table ${referencedTableName}`
           : `Found ${refCount} invalid foreign references to table ${referencedTableName}`;
-
         issues.push({
           type: IntegrityIssueType.MissingRecordReference,
+          fieldId: field.id,
           message: `${message} (Field Name: ${field.name}, Field ID: ${field.id})`,
         });
       }
@@ -165,6 +165,10 @@ export class ForeignKeyIntegrityService {
     targetTableName: string;
     keyName: string;
   }) {
+    if (!fkHostTableName.split('.')[1].startsWith('junction_')) {
+      throw new Error(`fkHostTableName: ${fkHostTableName} is not a junction table`);
+    }
+
     const deleteQuery = this.knex(fkHostTableName)
       .whereNotExists(
         this.knex

apps/nestjs-backend/src/features/integrity/link-field.service.ts

@@ -35,6 +35,7 @@ export class LinkFieldIntegrityService {
       return [
         {
           type: IntegrityIssueType.InvalidLinkReference,
+          fieldId: field.id,
           message: `Found ${inconsistentRecords.length} inconsistent links in fkHostTableName ${fkHostTableName} (TableName: ${table.name}, Field Name: ${field.name}, Field ID: ${field.id})`,
         },
       ];

apps/nestjs-backend/src/features/integrity/link-integrity.service.ts

@@ -118,6 +118,7 @@ export class LinkIntegrityService {
 
       if (!foreignTable) {
         issues.push({
+          fieldId: field.id,
           type: IntegrityIssueType.ForeignTableNotFound,
           message: `Foreign table with ID ${options.foreignTableId} not found for link field (Field Name: ${field.name}, Field ID: ${field.id}) in table ${table.name}`,
         });
@@ -129,6 +130,7 @@ export class LinkIntegrityService {
 
       if (!tableExists[0].exists) {
         issues.push({
+          fieldId: field.id,
           type: IntegrityIssueType.ForeignKeyHostTableNotFound,
           message: `Foreign key host table ${options.fkHostTableName} not found for link field (Field Name: ${field.name}, Field ID: ${field.id}) in table ${table.name}`,
         });
@@ -147,13 +149,15 @@ export class LinkIntegrityService {
 
         if (!selfKeyExists) {
           issues.push({
+            fieldId: field.id,
             type: IntegrityIssueType.ForeignKeyNotFound,
             message: `Self key name "${options.selfKeyName}" is missing for link field (Field Name: ${field.name}, Field ID: ${field.id}) in table ${table.name}`,
           });
         }
 
         if (!foreignKeyExists) {
           issues.push({
+            fieldId: field.id,
             type: IntegrityIssueType.ForeignKeyNotFound,
             message: `Foreign key name "${options.foreignKeyName}" is missing for link field (Field Name: ${field.name}, Field ID: ${field.id}) in table ${table.name}`,
           });
@@ -167,6 +171,7 @@ export class LinkIntegrityService {
 
         if (!symmetricField) {
           issues.push({
+            fieldId: field.id,
             type: IntegrityIssueType.SymmetricFieldNotFound,
             message: `Symmetric field ID ${options.symmetricFieldId} not found for link field (Field Name: ${field.name}, Field ID: ${field.id}) in table ${table.name}`,
           });
@@ -175,6 +180,7 @@ export class LinkIntegrityService {
 
       if (!options.isOneWay && !options.symmetricFieldId) {
         issues.push({
+          fieldId: field.id,
           type: IntegrityIssueType.SymmetricFieldNotFound,
           message: `Symmetric is missing for link field (Field Name: ${field.name}, Field ID: ${field.id}) in table ${table.name}`,
         });
@@ -203,21 +209,22 @@ export class LinkIntegrityService {
   async linkIntegrityFix(baseId: string): Promise<IIntegrityIssue[]> {
     const checkResult = await this.linkIntegrityCheck(baseId);
     const fixResults: IIntegrityIssue[] = [];
-
     for (const issues of checkResult.linkFieldIssues) {
       for (const issue of issues.issues) {
-        // eslint-disable-next-line sonarjs/no-small-switch
         switch (issue.type) {
           case IntegrityIssueType.MissingRecordReference: {
             const result = await this.foreignKeyIntegrityService.fix(
               issues.tableId,
-              issues.fieldId
+              issue.fieldId || issues.fieldId
             );
             result && fixResults.push(result);
             break;
           }
           case IntegrityIssueType.InvalidLinkReference: {
-            const result = await this.linkFieldIntegrityService.fix(issues.tableId, issues.fieldId);
+            const result = await this.linkFieldIntegrityService.fix(
+              issues.tableId,
+              issue.fieldId || issues.fieldId
+            );
             result && fixResults.push(result);
             break;
           }

packages/openapi/src/integrity/link-check.ts

@@ -20,6 +20,7 @@ export enum IntegrityIssueType {
 export const integrityIssueSchema = z.object({
   type: z.nativeEnum(IntegrityIssueType),
   message: z.string(),
+  fieldId: z.string().optional(),
 });
 
 // Define the schema for a link field check item