Merge branch 'feature/8' into develop

Author: suikan4github

CHANGELOG.md

@@ -6,6 +6,8 @@ History of the project development
 ### Changed
 - [Issue #4](https://github.com/suikan4github/rpp_driver/issues/4) Add gcov support for x86 build. 
 - [Issue #5](https://github.com/suikan4github/rpp_driver/issues/5) Migrate action from hand-made to marketplace.
+- [Issue #8](https://github.com/suikan4github/rpp_driver/issues/8)  Remove duplicated assertions in the adau1361lower.cpp.
+
 ### Deprecated
 ### Removed
 ### Fixed

src/codec/adau1361lower.cpp

@@ -86,10 +86,6 @@ void ::rpp_driver::Adau1361Lower::WaitPllLock(void) {
 // Configure PLL and start. Then, initiate the core and set the CODEC Fs.
 void ::rpp_driver::Adau1361Lower::ConfigurePll(unsigned int fs,
                                                unsigned int master_clock) {
-  assert((fs == 24000 || fs == 32000 || fs == 48000 || fs == 96000 ||
-          fs == 22050 || fs == 44100 || fs == 88200) &&
-         "Bad Fs");
-
   if (fs == 24000 || fs == 32000 || fs == 48000 || fs == 96000) {
     // Configure the PLL. Target PLL out is 49.152MHz = 1024xfs
     // Regarding X, R, M, N, check ADAU1361 Datasheet register R1.
@@ -446,7 +442,7 @@ void ::rpp_driver::Adau1361Lower::ConfigurePll(unsigned int fs,
     }
 
   } else {  // Fs must be checked at the top of this routine.
-    assert(false && "Wrong parameter validation");
+    assert(false && "Wrong Fs");
   }
 
 }  // ConfigurePlll

test/test_adau1361lower.cpp

@@ -1068,10 +1068,11 @@ TEST_F(Adau1361LowerDeathTest, ConfigurePll_wrong_fs) {
   // Test 27MHz master clock for Fs 48kHz series.
   {
     const unsigned int mclock = 8000000;
-    const unsigned int fs = 192000;
-    // check the assertion for bad mclock.
+    const unsigned int fs = 192000;  // FS 192kHz is not allowed.
+                                     // check the assertion for bad mclock.
 #ifndef NDEBUG
-    ASSERT_DEATH(codec_lower_->ConfigurePll(fs, mclock), "Bad Fs");
+    ASSERT_DEATH(codec_lower_->ConfigurePll(fs, mclock),
+                 "Wrong Fs");  // Have to assert.
 #endif
   }
 }  // ConfigurePll_wrong_fs