Skip to content

Commit 880e958

Browse files
committed
Upgrade swagger-core from version 2.2.42 to 2.2.43
1 parent 8ecc29a commit 880e958

18 files changed

Lines changed: 38 additions & 23 deletions

File tree

.gitignore

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,4 +143,6 @@ Desktop.ini
143143
######################
144144
# ESLint
145145
######################
146-
.eslintcache
146+
.eslintcache
147+
/CLAUDE.md
148+
/.claude/

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@
5555
<central-publishing-maven-plugin.version>0.7.0
5656
</central-publishing-maven-plugin.version>
5757
<flatten-maven-plugin.version>1.5.0</flatten-maven-plugin.version>
58-
<swagger-api.version>2.2.42</swagger-api.version>
58+
<swagger-api.version>2.2.43</swagger-api.version>
5959
<swagger-ui.version>5.31.0</swagger-ui.version>
6060
<gmavenplus-plugin.version>1.13.1</gmavenplus-plugin.version>
6161
<jjwt.version>0.9.1</jjwt.version>

springdoc-openapi-starter-common/src/main/java/org/springdoc/api/AbstractOpenApiResource.java

Lines changed: 16 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1239,15 +1239,25 @@ private void fillParametersList(Operation operation, Map<String, String> queryPa
12391239
if(methodAttributes.getSpringDocVersionStrategy() != null)
12401240
versionDefaultMap= methodAttributes.getSpringDocVersionStrategy().getVersionDefaultMap();
12411241
for (Entry<String, String> entry : queryParams.entrySet()) {
1242-
Parameter parameter = new Parameter();
12431242
String name = entry.getKey();
12441243
String value = entry.getValue();
12451244
String defaultValue = (versionDefaultMap != null) ? versionDefaultMap.get(name) : value;
1246-
parameter.setName(name);
1247-
parameter.setSchema(new StringSchema()._default(defaultValue)._enum(Collections.singletonList(value)));
1248-
parameter.setRequired(true);
1249-
parameter.setIn(ParameterIn.QUERY.toString());
1250-
GenericParameterService.mergeParameter(parametersList, parameter);
1245+
Optional<Parameter> existingParam = parametersList.stream()
1246+
.filter(p -> name.equals(p.getName()) && ParameterIn.QUERY.toString().equals(p.getIn()))
1247+
.findAny();
1248+
if (existingParam.isPresent() && existingParam.get().getSchema() != null
1249+
&& existingParam.get().getSchema().getEnum() != null
1250+
&& !existingParam.get().getSchema().getEnum().contains(value)) {
1251+
existingParam.get().getSchema().getEnum().add(value);
1252+
}
1253+
else {
1254+
Parameter parameter = new Parameter();
1255+
parameter.setName(name);
1256+
parameter.setSchema(new StringSchema()._default(defaultValue)._enum(new ArrayList<>(Collections.singletonList(value))));
1257+
parameter.setRequired(true);
1258+
parameter.setIn(ParameterIn.QUERY.toString());
1259+
GenericParameterService.mergeParameter(parametersList, parameter);
1260+
}
12511261
}
12521262
operation.setParameters(parametersList);
12531263
}

springdoc-openapi-starter-common/src/main/java/org/springdoc/core/service/GenericParameterService.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -332,6 +332,8 @@ private void setSchema(io.swagger.v3.oas.annotations.Parameter parameterDoc, Com
332332
}
333333
// Cast default value
334334
if (schema != null && schema.getDefault() != null) {
335+
Object resolvedDefault = resolveEmbeddedValuesAndExpressions(schema.getDefault().toString());
336+
schema.setDefault(resolvedDefault);
335337
PrimitiveType primitiveType = PrimitiveType.fromTypeAndFormat(schema.getType(), schema.getFormat());
336338
if (primitiveType != null) {
337339
Schema<?> primitiveSchema = primitiveType.createProperty();

springdoc-openapi-starter-webmvc-api/src/test/resources/results/3.0.1/app238-zh-CN.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@
4949
"in": "query",
5050
"required": true,
5151
"schema": {
52+
"minLength": 1,
5253
"type": "string"
5354
}
5455
}

springdoc-openapi-starter-webmvc-api/src/test/resources/results/3.0.1/app25.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@
5454
"required": false,
5555
"schema": {
5656
"type": "number",
57-
"example": 10
57+
"example": "10"
5858
}
5959
}
6060
],

springdoc-openapi-starter-webmvc-api/src/test/resources/results/3.1.0/app114.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@
5757
"properties": {
5858
"amount": {
5959
"type": "number",
60-
"example": 99.96
60+
"example": "99.96"
6161
},
6262
"currency": {
6363
"type": "string",

springdoc-openapi-starter-webmvc-api/src/test/resources/results/3.1.0/app25.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@
5454
"required": false,
5555
"schema": {
5656
"type": "number",
57-
"example": 10
57+
"example": "10"
5858
}
5959
}
6060
],

springdoc-openapi-starter-webmvc-api/src/test/resources/results/3.1.0/app29.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@
6868
"type": "number",
6969
"description": "The data value",
7070
"format": "double",
71-
"example": 19.0
71+
"example": "19.0"
7272
}
7373
}
7474
}

springdoc-openapi-starter-webmvc-api/src/test/resources/results/3.1.0/app4.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@
6565
"type": "number",
6666
"description": "The data value",
6767
"format": "double",
68-
"example": 19.0
68+
"example": "19.0"
6969
}
7070
}
7171
}

0 commit comments

Comments
 (0)