Skip to content

Commit e85f9a7

Browse files
committed
Prevent javascript access to auth cookie
1 parent a07a59e commit e85f9a7

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

Plan/common/src/main/java/com/djrapitops/plan/delivery/webserver/http/RequestHandler.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ private Response processFailedAuthentication(InternalRequest internalRequest, @U
124124
String directTo = Strings.CI.startsWithAny(from, "/auth/", "/login") ? "/login" : "/login?from=." + from;
125125
return Response.builder()
126126
.redirectTo(directTo)
127-
.setHeader("Set-Cookie", "auth=expired; Path=/; Max-Age=0; SameSite=Lax; Secure;")
127+
.setHeader("Set-Cookie", "auth=expired; Path=/; Max-Age=0; SameSite=Lax; Secure; HTTPOnly;")
128128
.build();
129129
}
130130
}

Plan/common/src/main/java/com/djrapitops/plan/delivery/webserver/resolver/auth/LoginResolver.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ public Optional<Response> resolve(Request request) {
8888
public Response getResponse(String cookie) {
8989
return Response.builder()
9090
.setStatus(200)
91-
.setHeader("Set-Cookie", "auth=" + cookie + "; Path=/; Max-Age=" + ActiveCookieStore.getCookieExpiresAfterMs() + "; SameSite=Lax; Secure;")
91+
.setHeader("Set-Cookie", "auth=" + cookie + "; Path=/; Max-Age=" + ActiveCookieStore.getCookieExpiresAfterMs() + "; SameSite=Lax; Secure; HTTPOnly;")
9292
.setJSONContent(Collections.singletonMap("success", true))
9393
.build();
9494
}

Plan/common/src/main/java/com/djrapitops/plan/delivery/webserver/resolver/auth/LogoutResolver.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ public Optional<Response> resolve(@Untrusted Request request) {
8080
public Response getResponse() {
8181
return Response.builder()
8282
.redirectTo("/login")
83-
.setHeader("Set-Cookie", "auth=expired; Max-Age=0; SameSite=Lax; Secure;")
83+
.setHeader("Set-Cookie", "auth=expired; Max-Age=0; SameSite=Lax; Secure; HTTPOnly;")
8484
.build();
8585
}
8686
}

0 commit comments

Comments
 (0)