Commit df5c585
authored
Fix proxy HTTPS address comparison missing replace argument (#4511)
`address.replace('http')` without a second argument replaces "http"
with the string "undefined" in JavaScript, causing `isCurrentAddress()`
to always return false when using an HTTPS reverse proxy in front of
Plan's HTTP server.
This breaks subpath routing — the React app falls back to an empty
`baseAddress`, so the router has no basename and API calls go to
relative paths instead of the configured address.
Adding the missing empty string argument (`address.replace('http', '')`)
correctly strips the protocol for comparison.1 parent eb96177 commit df5c585
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| |||
0 commit comments