Fix non-existent config updates being constantly applied

Author: AuroraLS3

Plan/common/src/main/java/com/djrapitops/plan/settings/config/ResourceSettings.java

@@ -41,6 +41,8 @@ public ResourceSettings(
     }
 
     public boolean shouldBeCustomized(String plugin, @Untrusted String fileName) {
+        if ("Plan".equals(plugin)) return false;
+
         ConfigNode fileCustomization = getCustomizationConfigNode();
         fileCustomization.setComment(Collections.singletonList("The files are placed in /Plan/web/ if the setting is 'true' when accessed."));
 

Plan/common/src/main/java/com/djrapitops/plan/settings/config/changes/ConfigChange.java

@@ -22,7 +22,6 @@
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.Optional;
-import java.util.function.Predicate;
 
 /**
  * Represents a change made to the config structure.
@@ -48,7 +47,9 @@ public Moved(String oldPath, String newPath) {
 
         @Override
         public synchronized void apply(Config config) {
-            if (!config.moveChild(oldPath, newPath)) {
+            if (config.getNode(newPath).isPresent()) {
+                super.apply(config);
+            } else if (!config.moveChild(oldPath, newPath)) {
                 throw new IllegalStateException("Failed to move config node from '" + oldPath + "' to '" + newPath + "'");
             }
         }
@@ -102,12 +103,12 @@ public MovedValue(String oldPath, String newPath) {
 
         @Override
         public boolean hasBeenApplied(Config config) {
-            return config.getNode(oldPath)
-                    .map(ConfigNode::getString)
-                    .map(String::trim)
-                    .filter(Predicate.not(String::isEmpty))
-                    .isEmpty()
-                    && config.getNode(newPath).isPresent();
+            Optional<ConfigNode> oldNode = config.getNode(oldPath);
+            Optional<ConfigNode> newNode = config.getNode(newPath);
+            if (oldNode.isPresent()) {
+                return false;
+            }
+            return newNode.isPresent();
         }
 
         @Override

Plan/common/src/main/java/com/djrapitops/plan/settings/config/changes/ConfigUpdater.java

@@ -165,7 +165,7 @@ ConfigChange[] configEnhancementPatch() {
                 new ConfigChange.MovedValue("Time.Thresholds.Remove_ping_data_after", "Time.Thresholds.Remove_ping_data_after.Time"),
                 new ConfigChange.MovedValue("Time.Thresholds.AFK_threshold", "Time.Thresholds.AFK_threshold.Time"),
                 new ConfigChange.MovedValue("Time.Thresholds.Remove_inactive_player_data_after", "Time.Thresholds.Remove_inactive_player_data_after.Time"),
-                new ConfigChange.MovedValue("Time.Periodic_tasks.Extension_data_refresh_every", "Time.Periodic_tasks.Extension_data_refresh_every.Time"),
+                new ConfigChange.MovedValue("Time.Periodic_tasks.Extension_data_refresh_every", "Time.Periodic_tasks.Extension_server_data_refresh_every.Time"),
                 new ConfigChange.MovedValue("Time.Periodic_tasks.Check_DB_for_server_config_files_every", "Time.Periodic_tasks.Check_DB_for_server_config_files_every.Time"),
                 new ConfigChange.MovedValue("Time.Periodic_tasks.Clean_Database_every", "Time.Periodic_tasks.Clean_Database_every.Time"),
                 new ConfigChange.MovedValue("Time.Delays.Ping_server_enable_delay", "Time.Delays.Ping_server_enable_delay.Time"),