Fix config changes being applied incorrectly

Affects issues:
- Fixed #4514

Author: AuroraLS3

Plan/common/src/main/java/com/djrapitops/plan/settings/config/changes/ConfigChange.java

@@ -105,10 +105,7 @@ public MovedValue(String oldPath, String newPath) {
         public boolean hasBeenApplied(Config config) {
             Optional<ConfigNode> oldNode = config.getNode(oldPath);
             Optional<ConfigNode> newNode = config.getNode(newPath);
-            if (oldNode.isPresent()) {
-                return false;
-            }
-            return newNode.isPresent();
+            return oldNode.isEmpty() || newNode.isPresent() && !newNode.get().getString().isEmpty();
         }
 
         @Override

Plan/common/src/test/java/com/djrapitops/plan/settings/config/changes/ConfigChangeTest.java

@@ -23,8 +23,14 @@
 import org.junit.jupiter.api.extension.ExtendWith;
 import org.junit.jupiter.api.io.TempDir;
 import org.mockito.junit.jupiter.MockitoExtension;
+import utilities.TestErrorLogger;
+import utilities.TestPluginLogger;
+import utilities.TestResources;
 
+import java.io.IOException;
+import java.nio.file.Files;
 import java.nio.file.Path;
+import java.util.List;
 import java.util.Scanner;
 
 import static org.junit.jupiter.api.Assertions.*;
@@ -145,4 +151,17 @@ void valueIsMoved() {
         assertEquals("anotherValue", config.getString("Test.Child"));
     }
 
+    @Test
+    void defaultConfigNeedsNoChanges() throws IOException {
+        config = prepareConfig(new String(TestResources.getJarResourceAsBytes(TestResources.CONFIG_PATH)));
+
+        List<String> originalLines = Files.readAllLines(config.getConfigFilePath());
+        TestPluginLogger logger = new TestPluginLogger();
+        logger.logMessages(true);
+        ConfigUpdater updater = new ConfigUpdater(logger, new TestErrorLogger());
+        updater.applyConfigUpdate(config);
+        List<String> unmodifiedLines = Files.readAllLines(config.getConfigFilePath());
+        assertEquals(List.of(), logger.getLogMessages());
+        assertEquals(originalLines, unmodifiedLines);
+    }
 }

Plan/common/src/testFixtures/java/utilities/TestPluginLogger.java

@@ -18,23 +18,41 @@
 
 import net.playeranalytics.plugin.server.PluginLogger;
 
+import java.util.ArrayList;
+import java.util.List;
+
 public class TestPluginLogger implements PluginLogger {
 
+    private final List<String> logMessages = new ArrayList<>();
+
+    private boolean addToList = false;
+
+    public void logMessages(boolean addToList) {
+        this.addToList = addToList;
+    }
+
+    public List<String> getLogMessages() {
+        return logMessages;
+    }
+
     @Override
     public PluginLogger info(String s) {
         System.out.println("[INFO] " + s);
+        if (addToList) logMessages.add(s);
         return this;
     }
 
     @Override
     public PluginLogger warn(String s) {
         System.out.println("[WARN] " + s);
+        if (addToList) logMessages.add(s);
         return this;
     }
 
     @Override
     public PluginLogger error(String s) {
         System.out.println("[ERROR] " + s);
+        if (addToList) logMessages.add(s);
         return this;
     }
 

Plan/common/src/testFixtures/java/utilities/TestResources.java

@@ -30,6 +30,8 @@
 
 public class TestResources {
 
+    public static final String CONFIG_PATH = "/assets/plan/config.yml";
+
     private TestResources() {
         /* static method class */
     }