Skip to content

Commit 5673b02

Browse files
authored
[RISCV][MC] Remove tautological CHECK-UNKNOWN disassembly checks (NFC) (#193682)
Many RISC-V MC tests assemble with `--mattr=+v` (or another extension), then run llvm-objdump on the result *without* `--mattr=`, expecting the disassembler to print `<unknown>` for every instruction. These CHECK-UNKNOWN lines only restate the encoded bytes that are already verified by CHECK-ENCODING from `llvm-mc -show-encoding`, so they do not add coverage. Drop the CHECK-UNKNOWN RUN lines and check directives from the affected tests to reduce noise and make the tests easier to read. The remaining CHECK-INST / CHECK-ENCODING / CHECK-ERROR coverage is unchanged. This is a preparatory cleanup that makes the upcoming llvm-objdump per-region disassembly change (using ISA mapping symbols #193448) easier to review. Assisted-by: Claude Opus I use Opus to write commit message...:P
1 parent 5a45fbb commit 5673b02

58 files changed

Lines changed: 0 additions & 1673 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

llvm/test/MC/RISCV/XTHeadVdot-valid.s

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -5,89 +5,73 @@
55
# RUN: llvm-mc -triple=riscv64 -filetype=obj --mattr=+xtheadvdot %s \
66
# RUN: | llvm-objdump -d --mattr=+xtheadvdot - \
77
# RUN: | FileCheck %s --check-prefix=CHECK-INST
8-
# RUN: llvm-mc -triple=riscv64 -filetype=obj --mattr=+xtheadvdot %s \
9-
# RUN: | llvm-objdump -d - | FileCheck %s --check-prefix=CHECK-UNKNOWN
108

119
th.vmaqau.vv v8, v20, v4, v0.t
1210
# CHECK-INST: th.vmaqau.vv v8, v20, v4, v0.t
1311
# CHECK-ENCODING: [0x0b,0x64,0x4a,0x88]
1412
# CHECK-ERROR: instruction requires the following: 'XTHeadVdot' (T-Head Vector Extensions for Dot){{$}}
15-
# CHECK-UNKNOWN: 884a640b <unknown>
1613

1714
th.vmaqau.vv v8, v20, v4
1815
# CHECK-INST: th.vmaqau.vv v8, v20, v4
1916
# CHECK-ENCODING: [0x0b,0x64,0x4a,0x8a]
2017
# CHECK-ERROR: instruction requires the following: 'XTHeadVdot' (T-Head Vector Extensions for Dot){{$}}
21-
# CHECK-UNKNOWN: 8a4a640b <unknown>
2218

2319
th.vmaqau.vx v8, a0, v4, v0.t
2420
# CHECK-INST: th.vmaqau.vx v8, a0, v4, v0.t
2521
# CHECK-ENCODING: [0x0b,0x64,0x45,0x8c]
2622
# CHECK-ERROR: instruction requires the following: 'XTHeadVdot' (T-Head Vector Extensions for Dot){{$}}
27-
# CHECK-UNKNOWN: 8c45640b <unknown>
2823

2924
th.vmaqau.vx v8, a0, v4
3025
# CHECK-INST: th.vmaqau.vx v8, a0, v4
3126
# CHECK-ENCODING: [0x0b,0x64,0x45,0x8e]
3227
# CHECK-ERROR: instruction requires the following: 'XTHeadVdot' (T-Head Vector Extensions for Dot){{$}}
33-
# CHECK-UNKNOWN: 8e45640b <unknown>
3428

3529
th.vmaqa.vv v8, v20, v4, v0.t
3630
# CHECK-INST: th.vmaqa.vv v8, v20, v4, v0.t
3731
# CHECK-ENCODING: [0x0b,0x64,0x4a,0x80]
3832
# CHECK-ERROR: instruction requires the following: 'XTHeadVdot' (T-Head Vector Extensions for Dot){{$}}
39-
# CHECK-UNKNOWN: 804a640b <unknown>
4033

4134
th.vmaqa.vv v8, v20, v4
4235
# CHECK-INST: th.vmaqa.vv v8, v20, v4
4336
# CHECK-ENCODING: [0x0b,0x64,0x4a,0x82]
4437
# CHECK-ERROR: instruction requires the following: 'XTHeadVdot' (T-Head Vector Extensions for Dot){{$}}
45-
# CHECK-UNKNOWN: 824a640b <unknown>
4638

4739
th.vmaqa.vx v8, a0, v4, v0.t
4840
# CHECK-INST: th.vmaqa.vx v8, a0, v4, v0.t
4941
# CHECK-ENCODING: [0x0b,0x64,0x45,0x84]
5042
# CHECK-ERROR: instruction requires the following: 'XTHeadVdot' (T-Head Vector Extensions for Dot){{$}}
51-
# CHECK-UNKNOWN: 8445640b <unknown>
5243

5344
th.vmaqa.vx v8, a0, v4
5445
# CHECK-INST: th.vmaqa.vx v8, a0, v4
5546
# CHECK-ENCODING: [0x0b,0x64,0x45,0x86]
5647
# CHECK-ERROR: instruction requires the following: 'XTHeadVdot' (T-Head Vector Extensions for Dot){{$}}
57-
# CHECK-UNKNOWN: 8645640b <unknown>
5848

5949
th.vmaqasu.vv v8, v20, v4, v0.t
6050
# CHECK-INST: th.vmaqasu.vv v8, v20, v4, v0.t
6151
# CHECK-ENCODING: [0x0b,0x64,0x4a,0x90]
6252
# CHECK-ERROR: instruction requires the following: 'XTHeadVdot' (T-Head Vector Extensions for Dot){{$}}
63-
# CHECK-UNKNOWN: 904a640b <unknown>
6453

6554
th.vmaqasu.vv v8, v20, v4
6655
# CHECK-INST: th.vmaqasu.vv v8, v20, v4
6756
# CHECK-ENCODING: [0x0b,0x64,0x4a,0x92]
6857
# CHECK-ERROR: instruction requires the following: 'XTHeadVdot' (T-Head Vector Extensions for Dot){{$}}
69-
# CHECK-UNKNOWN: 924a640b <unknown>
7058

7159
th.vmaqasu.vx v8, a0, v4, v0.t
7260
# CHECK-INST: th.vmaqasu.vx v8, a0, v4, v0.t
7361
# CHECK-ENCODING: [0x0b,0x64,0x45,0x94]
7462
# CHECK-ERROR: instruction requires the following: 'XTHeadVdot' (T-Head Vector Extensions for Dot){{$}}
75-
# CHECK-UNKNOWN: 9445640b <unknown>
7663

7764
th.vmaqasu.vx v8, a0, v4
7865
# CHECK-INST: th.vmaqasu.vx v8, a0, v4
7966
# CHECK-ENCODING: [0x0b,0x64,0x45,0x96]
8067
# CHECK-ERROR: instruction requires the following: 'XTHeadVdot' (T-Head Vector Extensions for Dot){{$}}
81-
# CHECK-UNKNOWN: 9645640b <unknown>
8268

8369
th.vmaqaus.vx v8, a0, v4, v0.t
8470
# CHECK-INST: th.vmaqaus.vx v8, a0, v4, v0.t
8571
# CHECK-ENCODING: [0x0b,0x64,0x45,0x9c]
8672
# CHECK-ERROR: instruction requires the following: 'XTHeadVdot' (T-Head Vector Extensions for Dot){{$}}
87-
# CHECK-UNKNOWN: 9c45640b <unknown>
8873

8974
th.vmaqaus.vx v8, a0, v4
9075
# CHECK-INST: th.vmaqaus.vx v8, a0, v4
9176
# CHECK-ENCODING: [0x0b,0x64,0x45,0x9e]
9277
# CHECK-ERROR: instruction requires the following: 'XTHeadVdot' (T-Head Vector Extensions for Dot){{$}}
93-
# CHECK-UNKNOWN: 9e45640b <unknown>

0 commit comments

Comments
 (0)