Skip to content

Commit 8fc6e8c

Browse files
authored
Remove folder warning from CLI deploy (#3108)
1 parent a0d39e8 commit 8fc6e8c

2 files changed

Lines changed: 1 addition & 19 deletions

File tree

lib/livebook/live_markdown/import.ex

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -667,22 +667,6 @@ defmodule Livebook.LiveMarkdown.Import do
667667
# validate it against the public key).
668668
teams_enabled = is_struct(hub, Livebook.Hubs.Team) and (hub.offline == nil or stamp_verified?)
669669

670-
messages =
671-
if app_folder_id = notebook.app_settings.app_folder_id do
672-
app_folders = Hubs.Provider.get_app_folders(hub)
673-
674-
if Enum.any?(app_folders, &(&1.id == app_folder_id)) do
675-
messages
676-
else
677-
messages ++
678-
[
679-
~s/notebook is assigned to a non-existent app folder, defaulting to "No folder" app folder/
680-
]
681-
end
682-
else
683-
messages
684-
end
685-
686670
{%{notebook | teams_enabled: teams_enabled}, stamp_verified?, messages}
687671
end
688672

test/livebook_teams/live_markdown/import_test.exs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,7 @@ defmodule Livebook.Integration.LiveMarkdown.ImportTest do
4242
assert {%Notebook{
4343
name: "Deleted from folder",
4444
app_settings: %{app_folder_id: ^app_folder_id}
45-
}, %{warnings: warnings}} = LiveMarkdown.Import.notebook_from_livemd(markdown)
46-
47-
assert "notebook is assigned to a non-existent app folder, defaulting to 'No folder' app folder" in warnings
45+
}, %{warnings: []}} = LiveMarkdown.Import.notebook_from_livemd(markdown)
4846
end
4947
end
5048
end

0 commit comments

Comments
 (0)