Restore logger wrappers as funcs and update docs

Agent-Logs-Url: https://github.com/github/gh-aw-mcpg/sessions/85f29738-c288-4e1b-a0a2-7e46c41d094f

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

Author: Copilot

internal/logger/common.go

@@ -183,32 +183,40 @@ import (
 
 // Log-Level Quad-Function Pattern
 //
-// Three sets of four public functions — one set per logger variant — share an identical
-// structural pattern where each function is a one-liner that delegates to an internal
-// helper with the appropriate LogLevel constant:
+// Three sets of four public functions — one set per logger variant — share an
+// identical structure where each exported one-liner delegates to an unexported
+// per-level closure created by helper constructors in this file:
 //
 //	func Log<Level>(category, format string, args ...interface{}) {
-//	    <internalHelper>(LogLevel<Level>, category, format, args...)
+//	    log<level>(category, format, args...)
 //	}
 //
-// The three sets and their internal helpers are:
+// The three sets and their internal dispatch helpers are:
 //
 //	file_logger.go       LogInfo / LogWarn / LogError / LogDebug          → logWithLevel
 //	markdown_logger.go   LogInfoMd / LogWarnMd / LogErrorMd / LogDebugMd  → logWithMarkdown
 //	server_file_logger.go LogInfoWithServer / ... / LogDebugWithServer    → logWithLevelAndServer
 //
-// This pattern is intentionally kept across the three files because:
+// This pattern keeps exported APIs immutable (`func` declarations) while still
+// eliminating repeated inline level wiring.
+//
+// The makeLevelLogger and makeServerLevelLogger helpers are for internal
+// delegation only and should not replace exported functions with reassignable
+// function variables.
+//
+// This remains intentionally consistent across the three files because:
 //   - Each set is a distinct public API with a different signature and set of callers.
-//   - The one-liner wrappers are trivial and unlikely to diverge.
-//   - Go lacks the metaprogramming to eliminate them without sacrificing readability.
+//   - The exported wrappers preserve a stable, non-mutable API surface.
+//   - Internal closure generation removes repetitive level-binding boilerplate.
 //
 // The shared logFuncs map below centralises the LogLevel → log-function
 // mapping so that the internal helpers (logWithMarkdown, logWithLevelAndServer)
 // do not need their own switch-on-level blocks.
 //
 // When adding a new LogLevel constant (e.g., LogLevelTrace):
 //  1. Add a new entry to the logFuncs map below.
-//  2. Add a new LogTrace wrapper to each of the three files above.
+//  2. Add a new internal per-level closure and exported wrapper in each of the
+//     three files above.
 //
 // logFuncs maps each LogLevel to its corresponding global log function.
 // This eliminates repeated switch-on-level blocks in logWithMarkdown

internal/logger/file_logger.go

@@ -114,16 +114,32 @@ func logWithLevel(level LogLevel, category, format string, args ...interface{})
 }
 
 var (
-	// LogInfo logs an informational message.
-	LogInfo = makeLevelLogger(logWithLevel, LogLevelInfo)
-	// LogWarn logs a warning message.
-	LogWarn = makeLevelLogger(logWithLevel, LogLevelWarn)
-	// LogError logs an error message.
-	LogError = makeLevelLogger(logWithLevel, LogLevelError)
-	// LogDebug logs a debug message.
-	LogDebug = makeLevelLogger(logWithLevel, LogLevelDebug)
+	logInfo  = makeLevelLogger(logWithLevel, LogLevelInfo)
+	logWarn  = makeLevelLogger(logWithLevel, LogLevelWarn)
+	logError = makeLevelLogger(logWithLevel, LogLevelError)
+	logDebug = makeLevelLogger(logWithLevel, LogLevelDebug)
 )
 
+// LogInfo logs an informational message.
+func LogInfo(category, format string, args ...interface{}) {
+	logInfo(category, format, args...)
+}
+
+// LogWarn logs a warning message.
+func LogWarn(category, format string, args ...interface{}) {
+	logWarn(category, format, args...)
+}
+
+// LogError logs an error message.
+func LogError(category, format string, args ...interface{}) {
+	logError(category, format, args...)
+}
+
+// LogDebug logs a debug message.
+func LogDebug(category, format string, args ...interface{}) {
+	logDebug(category, format, args...)
+}
+
 // CloseGlobalLogger closes the global file logger
 func CloseGlobalLogger() error {
 	return closeGlobalLogger(&globalLoggerMu, &globalFileLogger)

internal/logger/markdown_logger.go

@@ -181,16 +181,32 @@ func logWithMarkdown(level LogLevel, category, format string, args ...interface{
 }
 
 var (
-	// LogInfoMd logs to both regular and markdown loggers.
-	LogInfoMd = makeLevelLogger(logWithMarkdown, LogLevelInfo)
-	// LogWarnMd logs to both regular and markdown loggers.
-	LogWarnMd = makeLevelLogger(logWithMarkdown, LogLevelWarn)
-	// LogErrorMd logs to both regular and markdown loggers.
-	LogErrorMd = makeLevelLogger(logWithMarkdown, LogLevelError)
-	// LogDebugMd logs to both regular and markdown loggers.
-	LogDebugMd = makeLevelLogger(logWithMarkdown, LogLevelDebug)
+	logInfoMd  = makeLevelLogger(logWithMarkdown, LogLevelInfo)
+	logWarnMd  = makeLevelLogger(logWithMarkdown, LogLevelWarn)
+	logErrorMd = makeLevelLogger(logWithMarkdown, LogLevelError)
+	logDebugMd = makeLevelLogger(logWithMarkdown, LogLevelDebug)
 )
 
+// LogInfoMd logs to both regular and markdown loggers.
+func LogInfoMd(category, format string, args ...interface{}) {
+	logInfoMd(category, format, args...)
+}
+
+// LogWarnMd logs to both regular and markdown loggers.
+func LogWarnMd(category, format string, args ...interface{}) {
+	logWarnMd(category, format, args...)
+}
+
+// LogErrorMd logs to both regular and markdown loggers.
+func LogErrorMd(category, format string, args ...interface{}) {
+	logErrorMd(category, format, args...)
+}
+
+// LogDebugMd logs to both regular and markdown loggers.
+func LogDebugMd(category, format string, args ...interface{}) {
+	logDebugMd(category, format, args...)
+}
+
 // CloseMarkdownLogger closes the global markdown logger
 func CloseMarkdownLogger() error {
 	return closeGlobalLogger(&globalMarkdownMu, &globalMarkdownLogger)

internal/logger/server_file_logger.go

@@ -156,16 +156,32 @@ func logWithLevelAndServer(serverID string, level LogLevel, category, format str
 }
 
 var (
-	// LogInfoWithServer logs an informational message to the server-specific log file.
-	LogInfoWithServer = makeServerLevelLogger(logWithLevelAndServer, LogLevelInfo)
-	// LogWarnWithServer logs a warning message to the server-specific log file.
-	LogWarnWithServer = makeServerLevelLogger(logWithLevelAndServer, LogLevelWarn)
-	// LogErrorWithServer logs an error message to the server-specific log file.
-	LogErrorWithServer = makeServerLevelLogger(logWithLevelAndServer, LogLevelError)
-	// LogDebugWithServer logs a debug message to the server-specific log file.
-	LogDebugWithServer = makeServerLevelLogger(logWithLevelAndServer, LogLevelDebug)
+	logInfoWithServer  = makeServerLevelLogger(logWithLevelAndServer, LogLevelInfo)
+	logWarnWithServer  = makeServerLevelLogger(logWithLevelAndServer, LogLevelWarn)
+	logErrorWithServer = makeServerLevelLogger(logWithLevelAndServer, LogLevelError)
+	logDebugWithServer = makeServerLevelLogger(logWithLevelAndServer, LogLevelDebug)
 )
 
+// LogInfoWithServer logs an informational message to the server-specific log file.
+func LogInfoWithServer(serverID, category, format string, args ...interface{}) {
+	logInfoWithServer(serverID, category, format, args...)
+}
+
+// LogWarnWithServer logs a warning message to the server-specific log file.
+func LogWarnWithServer(serverID, category, format string, args ...interface{}) {
+	logWarnWithServer(serverID, category, format, args...)
+}
+
+// LogErrorWithServer logs an error message to the server-specific log file.
+func LogErrorWithServer(serverID, category, format string, args ...interface{}) {
+	logErrorWithServer(serverID, category, format, args...)
+}
+
+// LogDebugWithServer logs a debug message to the server-specific log file.
+func LogDebugWithServer(serverID, category, format string, args ...interface{}) {
+	logDebugWithServer(serverID, category, format, args...)
+}
+
 // CloseServerFileLogger closes the global server file logger
 func CloseServerFileLogger() error {
 	return closeGlobalLogger(&globalServerLoggerMu, &globalServerFileLogger)