Remove unnecessary volatile from fields in Libraries (#125274)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: stephentoub

src/libraries/Common/src/Interop/Unix/System.Native/Interop.MemfdCreate.cs

@@ -15,7 +15,7 @@ internal static partial class Sys
         [LibraryImport(Libraries.SystemNative, EntryPoint = "SystemNative_IsMemfdSupported", SetLastError = true)]
         private static partial int MemfdSupportedImpl();
 
-        private static volatile NullableBool s_memfdSupported;
+        private static NullableBool s_memfdSupported;
 
         internal static bool IsMemfdSupported
         {

src/libraries/Common/src/System/Console/ConsoleUtils.cs

@@ -6,7 +6,7 @@ namespace System
     internal static partial class ConsoleUtils
     {
         /// <summary>Whether to output ansi color strings.</summary>
-        private static volatile NullableBool s_emitAnsiColorCodes;
+        private static NullableBool s_emitAnsiColorCodes;
 
         /// <summary>Get whether to emit ANSI color codes.</summary>
         public static bool EmitAnsiColorCodes

src/libraries/Common/src/System/Security/Cryptography/Pkcs/Pkcs9ContentType.cs

@@ -62,6 +62,6 @@ public override void CopyFrom(AsnEncodedData asnEncodedData)
             return new Oid(contentTypeValue);
         }
 
-        private volatile Oid? _lazyContentType;
+        private Oid? _lazyContentType;
     }
 }

src/libraries/Common/src/System/Security/Cryptography/Pkcs/Pkcs9DocumentDescription.cs

@@ -81,6 +81,6 @@ private static byte[] Encode(string documentDescription)
             return PkcsHelpers.EncodeOctetString(octets);
         }
 
-        private volatile string? _lazyDocumentDescription;
+        private string? _lazyDocumentDescription;
     }
 }

src/libraries/Common/src/System/Security/Cryptography/Pkcs/Pkcs9DocumentName.cs

@@ -81,6 +81,6 @@ private static byte[] Encode(string documentName)
             return PkcsHelpers.EncodeOctetString(octets);
         }
 
-        private volatile string? _lazyDocumentName;
+        private string? _lazyDocumentName;
     }
 }

src/libraries/Common/src/System/Security/Cryptography/Pkcs/Pkcs9MessageDigest.cs

@@ -60,6 +60,6 @@ public override void CopyFrom(AsnEncodedData asnEncodedData)
             return PkcsHelpers.DecodeOctetString(rawData);
         }
 
-        private volatile byte[]? _lazyMessageDigest;
+        private byte[]? _lazyMessageDigest;
     }
 }

src/libraries/System.ComponentModel.Composition/src/System/ComponentModel/Composition/Hosting/ApplicationCatalog.cs

@@ -15,7 +15,7 @@ namespace System.ComponentModel.Composition.Hosting
     public partial class ApplicationCatalog : ComposablePartCatalog, ICompositionElement
     {
         private bool _isDisposed;
-        private volatile AggregateCatalog? _innerCatalog;
+        private AggregateCatalog? _innerCatalog;
         private readonly object _thisLock = new object();
         private readonly ICompositionElement? _definitionOrigin;
         private readonly ReflectionContext? _reflectionContext;

src/libraries/System.ComponentModel.Composition/src/System/ComponentModel/Composition/Hosting/AssemblyCatalog.cs

@@ -24,8 +24,8 @@ public class AssemblyCatalog : ComposablePartCatalog, ICompositionElement
     {
         private readonly object _thisLock = new object();
         private readonly ICompositionElement _definitionOrigin;
-        private volatile Assembly _assembly;
-        private volatile ComposablePartCatalog? _innerCatalog;
+        private Assembly _assembly;
+        private ComposablePartCatalog? _innerCatalog;
         private int _isDisposed;
 
         private readonly ReflectionContext? _reflectionContext;

src/libraries/System.ComponentModel.Composition/src/System/ComponentModel/Composition/Hosting/TypeCatalog.cs

@@ -26,7 +26,7 @@ public class TypeCatalog : ComposablePartCatalog, ICompositionElement
     {
         private readonly object _thisLock = new object();
         private Type[]? _types;
-        private volatile List<ComposablePartDefinition>? _parts;
+        private List<ComposablePartDefinition>? _parts;
         private volatile bool _isDisposed;
         private readonly ICompositionElement _definitionOrigin;
         private readonly Lazy<Dictionary<string, List<ComposablePartDefinition>>> _contractPartIndex;

src/libraries/System.ComponentModel.Composition/src/System/ComponentModel/Composition/Primitives/ComposablePartCatalog.cs

@@ -22,7 +22,7 @@ namespace System.ComponentModel.Composition.Primitives
     public abstract class ComposablePartCatalog : IEnumerable<ComposablePartDefinition>, IDisposable
     {
         private bool _isDisposed;
-        private volatile IQueryable<ComposablePartDefinition>? _queryableParts;
+        private IQueryable<ComposablePartDefinition>? _queryableParts;
 
         internal static readonly List<Tuple<ComposablePartDefinition, ExportDefinition>> _EmptyExportsList = new List<Tuple<ComposablePartDefinition, ExportDefinition>>();