Merge pull request #403 from mnottale/extract-error-message

mnottale · web-flow · commit 9f9c66800509 · 2018-10-04T15:01:36.000+02:00
extract: Improve error messages when app is not found.
diff --git a/internal/packager/extract.go b/internal/packager/extract.go
@@ -118,7 +118,8 @@ func Extract(name string, ops ...func(*types.App) error) (*types.App, error) {
 		}
 		// look for a docker image
 		ops = append(ops, types.WithSource(types.AppSourceImage))
-		return extractImage(name, ops...)
+		app, err := extractImage(name, ops...)
+		return app, errors.Wrapf(err, "cannot locate application %q in filesystem or registry", name)
 	}
 	if s.IsDir() {
 		// directory: already decompressed

Original file line number	Diff line number	Diff line change
`@@ -118,7 +118,8 @@ func Extract(name string, ops ...func(types.App) error) (types.App, error) {`
`118`	`118`	`}`
`119`	`119`	`// look for a docker image`
`120`	`120`	`ops = append(ops, types.WithSource(types.AppSourceImage))`
`121`		`- return extractImage(name, ops...)`
	`121`	`+ app, err := extractImage(name, ops...)`
	`122`	`+ return app, errors.Wrapf(err, "cannot locate application %q in filesystem or registry", name)`
`122`	`123`	`}`
`123`	`124`	`if s.IsDir() {`
`124`	`125`	`// directory: already decompressed`