Only change directory to the dir if we're using an image file format that actually uses a directory

Signed-off-by: Mike Parker <michael.parker@docker.com>

Author: Mike Parker

cmd/docker-app/deploy.go

@@ -77,8 +77,10 @@ func runDeploy(dockerCli command.Cli, flags *pflag.FlagSet, appname string, opts
 	if stackName == "" {
 		stackName = internal.AppNameFromDir(app.Name)
 	}
-	if err := os.Chdir(app.Path); err != nil {
-		return err
+	if app.Source.ShouldRunInsideDirectory() {
+		if err := os.Chdir(app.Path); err != nil {
+			return err
+		}
 	}
 	return stack.RunDeploy(dockerCli, flags, rendered, deployOrchestrator, options.Deploy{
 		Namespace:        stackName,

types/types.go

@@ -32,6 +32,11 @@ const (
 	AppSourceArchive
 )
 
+// ShouldRunInsideDirectory returns whether the package is run from a directory on disk
+func (a AppSourceKind) ShouldRunInsideDirectory() bool {
+	return a == AppSourceSplit || a == AppSourceImage || a == AppSourceArchive
+}
+
 // App represents an app
 type App struct {
 	Name    string