Merge pull request #221 from Dimrok/feature/fix-save

silvin-lubecki · web-flow · commit 0a1972674266 · 2018-06-13T11:30:54.000+02:00
Do not show success message if the save operation failed
diff --git a/cmd/docker-app/save.go b/cmd/docker-app/save.go
@@ -21,7 +21,7 @@ func saveCmd() *cobra.Command {
 		Args:  cli.RequiresMaxArgs(1),
 		RunE: func(cmd *cobra.Command, args []string) error {
 			imageName, err := packager.Save(firstOrEmpty(args), opts.namespace, opts.tag)
-			if imageName != "" {
+			if imageName != "" && err == nil {
 				fmt.Printf("Saved application as image: %s\n", imageName)
 			}
 			return err

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ func saveCmd() *cobra.Command {`
`21`	`21`	`Args: cli.RequiresMaxArgs(1),`
`22`	`22`	`RunE: func(cmd *cobra.Command, args []string) error {`
`23`	`23`	`imageName, err := packager.Save(firstOrEmpty(args), opts.namespace, opts.tag)`
`24`		`- if imageName != "" {`
	`24`	`+ if imageName != "" && err == nil {`
`25`	`25`	`fmt.Printf("Saved application as image: %s\n", imageName)`
`26`	`26`	`}`
`27`	`27`	`return err`