Revert breaking PRs (#4881)

# Description of Changes

Revert the following PRs that have caused some breakage:
```
a32cffa Finish refactoring out replay (#4850)
d639be0 Replay: some code motion & reuse `ReplayCommittedState` (#4849)
78d6b6f Update NativeAOT-LLVM infrastructure to current ABI (#4515)
d5c1738 Better module backtraces for panics and whatnot (#577)
6f23b19 Wait for database update to become durable (#4846)
81c9eab Add `spacetime lock/unlock` to prevent accidental database deletion (#4502)
809aebd Move field `replay_table_updated` to `ReplayCommittedState` (#4807)
21b58ef Update axum (#2713)
b5cadff Extract replay stuff out of `CommittedState`, part 1 (#4804)
```

I also updated the Python smoketests for breakage introduced in
#4502. Reverting that
PR caused conflicts, so this fix is more straightforward.

# API and ABI breaking changes

Maybe kind of, but we haven't released any of these.

# Expected complexity level and risk

1

# Testing

Ask @bfops about testing

---------

Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com>

Author: bfops

.github/workflows/ci.yml

@@ -102,10 +102,6 @@ jobs:
           cd $env:USERPROFILE\emsdk
           .\emsdk install 4.0.21
           .\emsdk activate 4.0.21
-          # Add emscripten to PATH for subsequent steps and subprocesses
-          $emsdkPath = "$env:USERPROFILE\emsdk\upstream\emscripten"
-          Add-Content -Path $env:GITHUB_PATH -Value $emsdkPath
-          Write-Host "Added $emsdkPath to PATH"
 
       - name: Install psql (Windows)
         if: runner.os == 'Windows'

Cargo.lock

@@ -156,8 +156,8 @@ arrayvec = "0.7.2"
 async-channel = "2.5"
 async-stream = "0.3.6"
 async-trait = "0.1.68"
-axum = { version = "0.8.4", features = ["tracing"] }
-axum-extra = { version = "0.10", features = ["typed-header"] }
+axum = { version = "0.7", features = ["tracing"] }
+axum-extra = { version = "0.9", features = ["typed-header"] }
 backtrace = "0.3.66"
 base64 = "0.21.2"
 bigdecimal = "0.4.7"

Cargo.toml

@@ -1,12 +1,9 @@
 #ifndef SPACETIMEDB_RUNTIME_REGISTRATION_H
 #define SPACETIMEDB_RUNTIME_REGISTRATION_H
 
-#include <atomic>
 #include <functional>
 #include <optional>
 #include <string>
-#include <type_traits>
-#include <utility>
 #include <vector>
 #include "../abi/opaque_types.h"
 #include "autogen/Lifecycle.g.h"
@@ -36,18 +33,6 @@ std::vector<uint8_t> ConsumeBytes(BytesSource source);
 void SetMultiplePrimaryKeyError(const std::string& table_name);
 void SetConstraintRegistrationError(const std::string& code, const std::string& details);
 
-template <typename F>
-__attribute__((noinline)) decltype(auto) __spacetimedb_begin_short_backtrace(F&& f) {
-    if constexpr (std::is_void_v<std::invoke_result_t<F>>) {
-        std::forward<F>(f)();
-        std::atomic_signal_fence(std::memory_order_seq_cst);
-    } else {
-        decltype(auto) result = std::forward<F>(f)();
-        std::atomic_signal_fence(std::memory_order_seq_cst);
-        return result;
-    }
-}
-
 } // namespace Internal
 } // namespace SpacetimeDB
 

crates/bindings-cpp/include/spacetimedb/internal/runtime_registration.h

@@ -337,9 +337,7 @@ class V10Builder {
         std::function<void(ReducerContext&, BytesSource)> handler;
         if constexpr (traits::arity == 1) {
             handler = [func](ReducerContext& ctx, BytesSource) {
-                auto result = __spacetimedb_begin_short_backtrace([&] {
-                    return func(ctx);
-                });
+                auto result = func(ctx);
                 if (result.is_err()) {
                     ::SpacetimeDB::fail_reducer(result.error());
                 }
@@ -351,9 +349,7 @@ class V10Builder {
                     bsatn::Reader reader(bytes.data(), bytes.size());
                     auto args = std::make_tuple(bsatn::deserialize<typename traits::template arg_t<Js + 1>>(reader)...);
                     std::apply([&ctx_inner, fn](auto&&... unpacked) {
-                        auto result = __spacetimedb_begin_short_backtrace([&] {
-                            return fn(ctx_inner, std::forward<decltype(unpacked)>(unpacked)...);
-                        });
+                        auto result = fn(ctx_inner, std::forward<decltype(unpacked)>(unpacked)...);
                         if (result.is_err()) {
                             ::SpacetimeDB::fail_reducer(result.error());
                         }
@@ -410,9 +406,7 @@ class V10Builder {
         std::function<void(ReducerContext&, BytesSource)> handler;
         if constexpr (traits::arity == 1) {
             handler = [func](ReducerContext& ctx, BytesSource) {
-                auto result = __spacetimedb_begin_short_backtrace([&] {
-                    return func(ctx);
-                });
+                auto result = func(ctx);
                 if (result.is_err()) {
                     ::SpacetimeDB::fail_reducer(result.error());
                 }
@@ -424,9 +418,7 @@ class V10Builder {
                     bsatn::Reader reader(bytes.data(), bytes.size());
                     auto args = std::make_tuple(bsatn::deserialize<typename traits::template arg_t<Js + 1>>(reader)...);
                     std::apply([&ctx_inner, fn](auto&&... unpacked) {
-                        auto result = __spacetimedb_begin_short_backtrace([&] {
-                            return fn(ctx_inner, std::forward<decltype(unpacked)>(unpacked)...);
-                        });
+                        auto result = fn(ctx_inner, std::forward<decltype(unpacked)>(unpacked)...);
                         if (result.is_err()) {
                             ::SpacetimeDB::fail_reducer(result.error());
                         }
@@ -469,9 +461,7 @@ class V10Builder {
             std::function<std::vector<uint8_t>(ViewContext&, BytesSource)> handler =
                 [func](ViewContext& ctx, BytesSource args_source) -> std::vector<uint8_t> {
                     (void)args_source;
-                    auto result = __spacetimedb_begin_short_backtrace([&] {
-                        return func(ctx);
-                    });
+                    auto result = func(ctx);
                     auto result_vec = view_result_to_vec(std::move(result));
                     IterBuf buf = IterBuf::take();
                     {
@@ -485,9 +475,7 @@ class V10Builder {
             std::function<std::vector<uint8_t>(AnonymousViewContext&, BytesSource)> handler =
                 [func](AnonymousViewContext& ctx, BytesSource args_source) -> std::vector<uint8_t> {
                     (void)args_source;
-                    auto result = __spacetimedb_begin_short_backtrace([&] {
-                        return func(ctx);
-                    });
+                    auto result = func(ctx);
                     auto result_vec = view_result_to_vec(std::move(result));
                     IterBuf buf = IterBuf::take();
                     {
@@ -537,9 +525,7 @@ class V10Builder {
         std::function<std::vector<uint8_t>(ProcedureContext&, BytesSource)> handler;
         if constexpr (traits::arity == 1) {
             handler = [func](ProcedureContext& ctx, BytesSource) -> std::vector<uint8_t> {
-                auto result = __spacetimedb_begin_short_backtrace([&] {
-                    return func(ctx);
-                });
+                auto result = func(ctx);
                 IterBuf buf = IterBuf::take();
                 {
                     bsatn::Writer writer(buf.get());
@@ -553,11 +539,9 @@ class V10Builder {
                 return []<std::size_t... Js>(std::index_sequence<Js...>, Func fn, ProcedureContext& ctx_inner, const std::vector<uint8_t>& bytes) -> std::vector<uint8_t> {
                     bsatn::Reader reader(bytes.data(), bytes.size());
                     auto args = std::make_tuple(bsatn::deserialize<typename traits::template arg_t<Js + 1>>(reader)...);
-                    auto result = __spacetimedb_begin_short_backtrace([&] {
-                        return std::apply([&ctx_inner, fn](auto&&... unpacked) {
-                            return fn(ctx_inner, std::forward<decltype(unpacked)>(unpacked)...);
-                        }, args);
-                    });
+                    auto result = std::apply([&ctx_inner, fn](auto&&... unpacked) {
+                        return fn(ctx_inner, std::forward<decltype(unpacked)>(unpacked)...);
+                    }, args);
                     IterBuf buf = IterBuf::take();
                     {
                         bsatn::Writer writer(buf.get());