extensions: image-output-abl: quote variables in destructive commands (#9400 P0)

Quote all variable expansions passed to rm, mount, umount, losetup,
mkfs, sed -i, cp, truncate, blkid, gzip, cat, e2fsck, resize2fs, and
source to prevent word splitting. Replace `[ ! -z ]` with `[[ -n ]]`.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: iav

extensions/image-output-abl.sh

@@ -5,73 +5,73 @@ function add_host_dependencies__abl_host_deps() {
 function post_build_image__900_convert_to_abl_img() {
 	[[ -z $version ]] && exit_with_error "version is not set"
 
-	if [ ! -z "$UEFI_GRUB_TARGET" ]; then
+	if [[ -n "$UEFI_GRUB_TARGET" ]]; then
 		display_alert "Ignore" "${EXTENSION}" "info"
 		return 0
 	fi
 
-	if [ ! -z "$BOOTFS_TYPE" ]; then
+	if [[ -n "$BOOTFS_TYPE" ]]; then
 		return 0
 	fi
 
 	display_alert "Converting image $version to rootfs" "${EXTENSION}" "info"
 	declare -g ROOTFS_IMAGE_FILE="${DESTIMG}/${version}.rootfs.img"
-	rootfs_start_sector=$(gdisk -l ${DESTIMG}/${version}.img | grep rootfs | awk '{print $2}')
-	rootfs_end_sector=$(gdisk -l ${DESTIMG}/${version}.img | grep rootfs | awk '{print $3}')
+	rootfs_start_sector=$(gdisk -l "${DESTIMG}/${version}.img" | grep rootfs | awk '{print $2}')
+	rootfs_end_sector=$(gdisk -l "${DESTIMG}/${version}.img" | grep rootfs | awk '{print $3}')
 	old_rootfs_image_mount_dir=${DESTIMG}/rootfs-old
 	new_rootfs_image_mount_dir=${DESTIMG}/rootfs-new
-	mkdir -p ${old_rootfs_image_mount_dir} ${new_rootfs_image_mount_dir}
-	truncate --size=9728M ${ROOTFS_IMAGE_FILE}
-	mkfs.ext4 -F ${ROOTFS_IMAGE_FILE}
-	new_rootfs_image_uuid=$(blkid -s UUID -o value ${ROOTFS_IMAGE_FILE})
-	old_image_loop_device=$(losetup -f -P --show ${DESTIMG}/${version}.img)
-	old_rootfs_image_uuid=$(blkid -s UUID -o value ${old_image_loop_device}p1)
-	mount ${old_image_loop_device}p1 ${old_rootfs_image_mount_dir}
-	mount ${ROOTFS_IMAGE_FILE} ${new_rootfs_image_mount_dir}
-	cp -rfp ${old_rootfs_image_mount_dir}/* ${new_rootfs_image_mount_dir}/
-	umount ${old_rootfs_image_mount_dir}
-	losetup -d ${old_image_loop_device}
-	rm ${DESTIMG}/${version}.img
+	mkdir -p "${old_rootfs_image_mount_dir}" "${new_rootfs_image_mount_dir}"
+	truncate --size=9728M "${ROOTFS_IMAGE_FILE}"
+	mkfs.ext4 -F "${ROOTFS_IMAGE_FILE}"
+	new_rootfs_image_uuid=$(blkid -s UUID -o value "${ROOTFS_IMAGE_FILE}")
+	old_image_loop_device=$(losetup -f -P --show "${DESTIMG}/${version}.img")
+	old_rootfs_image_uuid=$(blkid -s UUID -o value "${old_image_loop_device}p1")
+	mount "${old_image_loop_device}p1" "${old_rootfs_image_mount_dir}"
+	mount "${ROOTFS_IMAGE_FILE}" "${new_rootfs_image_mount_dir}"
+	cp -rfp "${old_rootfs_image_mount_dir}"/* "${new_rootfs_image_mount_dir}"/
+	umount "${old_rootfs_image_mount_dir}"
+	losetup -d "${old_image_loop_device}"
+	rm "${DESTIMG}/${version}.img"
 	display_alert "Replace root partition uuid from ${old_rootfs_image_uuid} to ${new_rootfs_image_uuid} in /etc/fstab" "${EXTENSION}" "info"
-	sed -i "s|${old_rootfs_image_uuid}|${new_rootfs_image_uuid}|g" ${new_rootfs_image_mount_dir}/etc/fstab
-	source ${new_rootfs_image_mount_dir}/boot/armbianEnv.txt
+	sed -i "s|${old_rootfs_image_uuid}|${new_rootfs_image_uuid}|g" "${new_rootfs_image_mount_dir}/etc/fstab"
+	source "${new_rootfs_image_mount_dir}/boot/armbianEnv.txt"
 	declare -g bootimg_cmdline="${BOOTIMG_CMDLINE_EXTRA} root=UUID=${new_rootfs_image_uuid} slot_suffix=${abl_boot_partition_label#boot} ${extraargs}"
 
-	if [ ${#ABL_DTB_LIST[@]} -ne 0 ]; then
+	if [[ ${#ABL_DTB_LIST[@]} -ne 0 ]]; then
 		display_alert "Going to create abl kernel boot image" "${EXTENSION}" "info"
-		gzip -c ${new_rootfs_image_mount_dir}/boot/vmlinuz-*-* > ${DESTIMG}/Image.gz
+		gzip -c "${new_rootfs_image_mount_dir}"/boot/vmlinuz-*-* > "${DESTIMG}/Image.gz"
 		for dtb_name in "${ABL_DTB_LIST[@]}"; do
 			display_alert "Creatng abl kernel boot image with dtb ${dtb_name} and cmdline ${bootimg_cmdline} " "${EXTENSION}" "info"
-			cat ${DESTIMG}/Image.gz ${new_rootfs_image_mount_dir}/usr/lib/linux-image-*/qcom/${dtb_name}.dtb > ${DESTIMG}/Image.gz-${dtb_name}
+			cat "${DESTIMG}/Image.gz" "${new_rootfs_image_mount_dir}"/usr/lib/linux-image-*/qcom/"${dtb_name}.dtb" > "${DESTIMG}/Image.gz-${dtb_name}"
 			/usr/bin/mkbootimg \
-				--kernel ${DESTIMG}/Image.gz-${dtb_name} \
-				--ramdisk ${new_rootfs_image_mount_dir}/boot/initrd.img-*-* \
+				--kernel "${DESTIMG}/Image.gz-${dtb_name}" \
+				--ramdisk "${new_rootfs_image_mount_dir}"/boot/initrd.img-*-* \
 				--base 0x0 \
 				--second_offset 0x00f00000 \
 				--cmdline "${bootimg_cmdline}" \
 				--kernel_offset 0x8000 \
 				--ramdisk_offset 0x1000000 \
 				--tags_offset 0x100 \
 				--pagesize 4096 \
-				-o ${DESTIMG}/${version}.boot_${dtb_name}.img
+				-o "${DESTIMG}/${version}.boot_${dtb_name}.img"
 		done
 		display_alert "Creatng abl kernel boot recovery image with dtb ${ABL_DTB_LIST[0]}" "${EXTENSION}" "info"
-		cat ${DESTIMG}/Image.gz ${new_rootfs_image_mount_dir}/usr/lib/linux-image-*/qcom/${dtb_name}.dtb > ${DESTIMG}/Image.gz-${dtb_name}
+		cat "${DESTIMG}/Image.gz" "${new_rootfs_image_mount_dir}"/usr/lib/linux-image-*/qcom/"${dtb_name}.dtb" > "${DESTIMG}/Image.gz-${dtb_name}"
 		/usr/bin/mkbootimg \
-			--kernel ${DESTIMG}/Image.gz-${ABL_DTB_LIST[0]} \
-			--ramdisk ${new_rootfs_image_mount_dir}/boot/initrd.img-*-* \
+			--kernel "${DESTIMG}/Image.gz-${ABL_DTB_LIST[0]}" \
+			--ramdisk "${new_rootfs_image_mount_dir}"/boot/initrd.img-*-* \
 			--base 0x0 \
 			--second_offset 0x00f00000 \
 			--kernel_offset 0x8000 \
 			--ramdisk_offset 0x1000000 \
 			--tags_offset 0x100 \
 			--pagesize 4096 \
-			-o ${DESTIMG}/${version}.boot_recovery.img
+			-o "${DESTIMG}/${version}.boot_recovery.img"
 	fi
 
-	umount ${new_rootfs_image_mount_dir}
-	rm -rf ${new_rootfs_image_mount_dir}
-	e2fsck -p -f ${ROOTFS_IMAGE_FILE}
-	resize2fs -M ${ROOTFS_IMAGE_FILE}
+	umount "${new_rootfs_image_mount_dir}"
+	rm -rf "${new_rootfs_image_mount_dir}"
+	e2fsck -p -f "${ROOTFS_IMAGE_FILE}"
+	resize2fs -M "${ROOTFS_IMAGE_FILE}"
 	return 0
 }