build: clean up chroot environment + systemd disable noise

chroot_custom / chroot_custom_long_running: add LC_ALL="C" LANG="C"
LANGUAGE="" SUDO_USER="" (parity with chroot_sdcard/chroot_mount).

disable_systemd_service_sdcard: use systemctl --root= instead of
D-Bus; output at debug level only.

Author: igorpecovnik

lib/functions/logging/runners.sh

@@ -156,13 +156,13 @@ function chroot_sdcard_with_stdout() {
 function chroot_custom_long_running() { # any pipe causes the left-hand side to subshell and caos ensues. it's just like chroot_custom()
 	local target=$1
 	shift
-	raw_command="$*" raw_extra="chroot_custom_long_running" TMPDIR="" run_host_command_logged_raw chroot "${target}" /usr/bin/env bash -e -o pipefail -c "$*"
+	raw_command="$*" raw_extra="chroot_custom_long_running" TMPDIR="" LC_ALL="C" LANG="C" LANGUAGE="" SUDO_USER="" run_host_command_logged_raw chroot "${target}" /usr/bin/env bash -e -o pipefail -c "$*"
 }
 
 function chroot_custom() {
 	local target=$1
 	shift
-	raw_command="$*" raw_extra="chroot_custom" TMPDIR="" run_host_command_logged_raw chroot "${target}" /usr/bin/env bash -e -o pipefail -c "$*"
+	raw_command="$*" raw_extra="chroot_custom" TMPDIR="" LC_ALL="C" LANG="C" LANGUAGE="" SUDO_USER="" run_host_command_logged_raw chroot "${target}" /usr/bin/env bash -e -o pipefail -c "$*"
 }
 
 # For installing packages host-side. Not chroot!

lib/functions/rootfs/systemd-utils.sh

@@ -9,8 +9,12 @@
 
 function disable_systemd_service_sdcard() {
 	display_alert "Disabling systemd service(s) on target" "${*}" "debug"
-	declare service
+	declare service stderr_output
 	for service in "${@}"; do
-		chroot_sdcard systemctl --no-reload disable "${service}" "||" true
+		# Use --root= to operate directly on the chroot filesystem
+		# instead of talking to the host's systemd via D-Bus (which
+		# doesn't know about the chroot's unit files).
+		stderr_output="$(systemctl --root="${SDCARD}" --no-reload disable "${service}" 2>&1)" || true
+		[[ -n "${stderr_output}" ]] && display_alert "systemctl disable ${service}" "${stderr_output}" "debug"
 	done
 }