fixup! feat(rootfs-to-image): support ROOTFS_EXPORT_DIR and configurable ROOTFS_COMPRESSION

Author: iav

lib/functions/image/rootfs-to-image.sh

@@ -121,18 +121,24 @@ function create_image_from_sdcard_rootfs() {
 		declare -g ROOTFS_ARCHIVE_PATH=""
 		if [[ "${rootfs_compression}" != "none" ]]; then
 			ROOTFS_ARCHIVE_PATH="${FINALDEST}/${version}-rootfs.${archive_ext}"
+			# Write under DESTIMG (cleanup-managed) and publish atomically on success —
+			# otherwise a truncated archive from a failed tar/pv/compressor stage lingers
+			# in FINALDEST and looks like a valid artifact.
+			declare rootfs_archive_tmp="${DESTIMG}/${version}-rootfs.${archive_ext}"
 			display_alert "Creating rootfs archive" "${version}-rootfs.${archive_ext}" "info"
 			# Subshell with pipefail so failures in tar/pv propagate (otherwise the
 			# exit code of the final compressor stage hides truncation mid-archive).
 			declare -a tar_excludes=(--exclude='./boot/*' --exclude='./dev/*' --exclude='./proc/*' --exclude='./run/*' --exclude='./tmp/*' --exclude='./sys/*')
 			[[ "${INCLUDE_HOME_DIR:-no}" != "yes" ]] && tar_excludes+=(--exclude='./home/*')
+			rm -f "${rootfs_archive_tmp}"
 			(
 				set -o pipefail
 				tar cp --xattrs --directory="$SDCARD/" "${tar_excludes[@]}" . |
 					pv -p -b -r -s "$(du -sb "$SDCARD"/ | cut -f1)" \
 						-N "$(logging_echo_prefix_for_pv "create_rootfs_archive") rootfs.${archive_ext}" |
-					${archive_filter} > "${ROOTFS_ARCHIVE_PATH}"
+					${archive_filter} > "${rootfs_archive_tmp}"
 			)
+			run_host_command_logged mv -v "${rootfs_archive_tmp}" "${ROOTFS_ARCHIVE_PATH}"
 		fi
 
 		# ROOTFS_EXPORT_DIR: when set, also rsync rootfs tree into this directory.