artifact-rootfs: stop forcing SKIP_ARMBIAN_REPO=yes; default to no

artifact_rootfs_cli_adapter_config_prep set SKIP_ARMBIAN_REPO=yes
unconditionally, which made sense when rootfs assembly only
needed the distro archive. It doesn't anymore: the new desktop
install path runs 'armbian-config --api module_desktops install
mode=build' from inside rootfs-create.sh (see earlier commit in
this PR), and armbian-config itself lives in the <release>-utils
component of apt.armbian.com, with firefox / chromium / GNOME
branding in <release>-desktop.

With SKIP_ARMBIAN_REPO=yes forced on, the install step would hit
'E: Unable to locate package armbian-config' at rootfs-create
time for every desktop build. Default the variable to 'no'
instead, so apt.armbian.com is attached during rootfs assembly,
and make it a readonly '-g -r' declaration so a hook can't flip
it back under our feet. Boards / userpatches that still need the
old repo-free behaviour (air-gapped mirror setups, exotic
embedded use cases) can still pre-set SKIP_ARMBIAN_REPO=yes
before the function runs — the ':-' default only kicks in when
it's unset.

Author: igorpecovnik

config/boards/README.md

@@ -61,10 +61,10 @@ If you are unsure about the documentation then invoke `$ grep -r -A5 -B5 "BUILD_
 - **MODULES_BLACKLIST_EDGE** ( space-separated list of kernel modules ): appends modules to the kernel's blacklist/deny list for **edge** kernel
 - **SERIALCON** ( comma-separated list of terminal interfaces [:bandwidth] ): declares which serial console should be used on the system
 	- Example: `ttyS0:15000000,ttyGS1`
-- **SKIP_ARMBIAN_REPO** ( boolean ): Whether to include the armbian repository in the built image
+- **SKIP_ARMBIAN_REPO** ( boolean ): Whether to exclude the armbian repository from the built image
     - Values:
-        - yes: Include (default)
-        - no: Do NO include
+        - yes: Exclude the armbian repo (armbian.sources stays `.disabled`)
+        - no: Include the armbian repo (default)
 - **POWER_MANAGEMENT_FEATURES** (boolean): Controls whether system sleep functionality (suspend, hibernate, hybrid sleep) is allowed on the built image.
     - Values:
          - yes: Enable power-management sleep features (allow systemd sleep modes)

lib/functions/artifacts/artifact-rootfs.sh

@@ -151,9 +151,15 @@ function artifact_rootfs_cli_adapter_config_prep() {
 	declare -g -r RELEASE="${RELEASE}" # make readonly for finding who tries to change it
 	declare -g -r NEEDS_BINFMT="yes"   # make sure binfmts are installed during prepare_host_interactive
 
-	if [[ "${SKIP_ARMBIAN_REPO}" != "yes" ]]; then # if not set to yes, force it to yes.
-		declare -g SKIP_ARMBIAN_REPO="yes"            # Using the repo during rootfs build causes insanity, so don't. Make readonly to ensure.
-	fi
+	# Don't force SKIP_ARMBIAN_REPO=yes for rootfs artifact builds anymore.
+	# The new desktop install path (module_desktops install mode=build,
+	# invoked from rootfs-create.sh) needs apt.armbian.com's
+	# <release>-utils (armbian-config itself) and <release>-desktop
+	# (firefox, chromium, gnome-branded bits) components to be reachable
+	# while the rootfs is being assembled. Default to "no" (repo ON)
+	# and let boards/userpatches opt out explicitly if they still need
+	# the repo-free rootfs behaviour for whatever reason.
+	declare -g SKIP_ARMBIAN_REPO="${SKIP_ARMBIAN_REPO:-no}"
 	declare -g -r SKIP_ARMBIAN_REPO # make it readonly to ensure sanity if hooks try to change it
 
 	track_general_config_variables "in artifact_rootfs_cli_adapter_config_prep"