test(firewall): add test for skip-confirmation=0 behavior

Verifies that --skip-confirmation 0 correctly requires confirmation
even for a single rule modification, ensuring users can always opt
into manual confirmation for safety.

Author: mgajda

internal/commands/server/firewall/rule_disable_test.go

@@ -24,6 +24,7 @@ func TestRuleDisableCommand(t *testing.T) {
 				Direction: "in",
 				Action:    "accept",
 				Protocol:  "tcp",
+				Comment:   "Test rule",
 			},
 			{
 				Position:  2,
@@ -119,6 +120,12 @@ func TestRuleDisableCommand(t *testing.T) {
 			arg:         serverUUID,
 			expectedErr: "firewall rule at position 99 not found on server",
 		},
+		{
+			name:        "Skip confirmation set to 0 requires confirmation for single rule",
+			flags:       []string{"--comment", "Test", "--skip-confirmation", "0"},
+			arg:         serverUUID,
+			expectedErr: "would disable 1 rules (exceeds skip-confirmation=0)",
+		},
 	} {
 		t.Run(test.name, func(t *testing.T) {
 			mService := smock.Service{}

internal/commands/server/firewall/rule_enable_test.go

@@ -24,6 +24,7 @@ func TestRuleEnableCommand(t *testing.T) {
 				Direction: "in",
 				Action:    "drop",
 				Protocol:  "tcp",
+				Comment:   "Test rule",
 			},
 			{
 				Position:  2,
@@ -97,6 +98,12 @@ func TestRuleEnableCommand(t *testing.T) {
 			arg:         serverUUID,
 			expectedErr: "firewall rule at position 99 not found on server",
 		},
+		{
+			name:        "Skip confirmation set to 0 requires confirmation for single rule",
+			flags:       []string{"--comment", "Test", "--skip-confirmation", "0"},
+			arg:         serverUUID,
+			expectedErr: "would enable 1 rules (exceeds skip-confirmation=0)",
+		},
 	} {
 		t.Run(test.name, func(t *testing.T) {
 			mService := smock.Service{}