Conversation
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Checkstyle was already requiring JDK 21 and now about libraries need it too Use the kotlin extension method as it will also configure it for java code Ref: https://kotlinlang.org/docs/gradle-configure-project.html#gradle-java-toolchains-support Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
|
The linked Gradle docs also say
I know there was #12923 which already attempted to add it but it was closed. I'd be okay with not adding the resolver plugin so that people need to actively decide which JDK to download and use if they do not have a matching JDK on the machine. I just wanted to put this to debate as it is in the docs right below your linked changes and recommended. Apart from that, LGTM. |
My reasoning for that was as you say. People should have an appropriate JDK installed on their machines. Gradle sync itself is already quite big and consumes lot of data and then JDK will do that as well. If other projects go with another JDK, the contributors will be spending more and more data for each type of JDK. Then, of course, this will open the can of questions of why this JDK and not that JDK. Best is to leave it to the contributors to decide for themselves. |
2 participants
What is it?
refactorbranchDescription of the changes in your PR
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence