Merge dev into refactor by theimpulson · Pull Request #13420 · TeamNewPipe/NewPipe

theimpulson · 2026-04-14T14:25:44Z

What is it?

Bugfix (user facing)
Feature (user facing) ⚠️ Your PR must target the refactor branch
Codebase improvement (dev facing)
Meta improvement to the project (dev facing)

Fixes the following issue(s)

Contains a major fix users facing along with all other new changes of dev branch.

Fixes Refactor Nightly crash on download video. #13294

Description of the changes in your PR

Merges new changes into refactor

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

I read the contribution guidelines.
The proposed changes follow the AI policy.
I tested the changes using an emulator or a physical device.

height x width was used before which is an uncommon order.

Currently translated at 2.2% (2 of 89 strings) Translated using Weblate (Georgian) Currently translated at 55.0% (49 of 89 strings) Translated using Weblate (Latvian) Currently translated at 97.9% (748 of 764 strings) Translated using Weblate (Georgian) Currently translated at 96.5% (738 of 764 strings) Co-authored-by: Flavjo Avdiu <flavjoavdiu10@gmail.com> Co-authored-by: Hosted Weblate <hosted@weblate.org> Co-authored-by: Nikoloz <nukushatugushi@gmail.com> Co-authored-by: ℂ𝕠𝕠𝕠𝕝 (𝕘𝕚𝕥𝕙𝕦𝕓.𝕔𝕠𝕞/ℂ𝕠𝕠𝕠𝕝) <coool@mail.lv> Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/ka/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/sq/ Translation: NewPipe/Metadata

Correctly retrieve menu item inside download dialog

…ages

Add warning banner about ongoing google certification for android apps

`getQuantity()` was being called in a couple of places with `zeroCaseStringId=0`, but that wasn't documented anywhere, and if `count==0` then `getString(zeroCaseStringId /* == 0 */)` would be returned which doesn't make sense

Fix inconsistency in getQuantity and add docs

Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Greek) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Czech) Currently translated at 100.0% (89 of 89 strings) Translated using Weblate (Greek) Currently translated at 99.8% (764 of 765 strings) Translated using Weblate (Polish) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Portuguese (Brazil)) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Estonian) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Chinese (Simplified Han script)) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Swedish) Currently translated at 96.6% (86 of 89 strings) Co-authored-by: Agnieszka C <aga_04@o2.pl> Co-authored-by: Fjuro <fjuro@users.noreply.hosted.weblate.org> Co-authored-by: Hosted Weblate <hosted@weblate.org> Co-authored-by: Mickaël Binos <mickaelbinos@outlook.com> Co-authored-by: Mona Lisa <nickwick@users.noreply.hosted.weblate.org> Co-authored-by: Priit Jõerüüt <jrthwlate@users.noreply.hosted.weblate.org> Co-authored-by: Vasilis K. <skyhirules@gmail.com> Co-authored-by: delvani <del.cidrak@users.noreply.hosted.weblate.org> Co-authored-by: 大王叫我来巡山 <hamburger2048@users.noreply.hosted.weblate.org> Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/cs/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/sv/ Translation: NewPipe/Metadata

(cherry picked from commit 0020a02)

…0.28.4

Make error panel and error activity exception message URLs clickable via extension method Change ErrorMessage.getString to getText and return CharSequence, and use getText with formatArgs to preserve styling (i.e. URLs)

Currently translated at 97.9% (749 of 765 strings) Translated using Weblate (Latvian) Currently translated at 97.9% (749 of 765 strings) Translated using Weblate (Latvian) Currently translated at 18.8% (17 of 90 strings) Translated using Weblate (Latvian) Currently translated at 96.9% (742 of 765 strings) Translated using Weblate (Latvian) Currently translated at 97.3% (745 of 765 strings) Translated using Weblate (Ukrainian) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Latvian) Currently translated at 17.7% (16 of 90 strings) Translated using Weblate (Turkish) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Russian) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Italian) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Portuguese) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Armenian) Currently translated at 31.6% (242 of 765 strings) Translated using Weblate (Portuguese (Portugal)) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Slovak) Currently translated at 76.6% (69 of 90 strings) Translated using Weblate (Azerbaijani) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Slovak) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Japanese) Currently translated at 13.3% (12 of 90 strings) Translated using Weblate (Czech) Currently translated at 100.0% (90 of 90 strings) Translated using Weblate (Korean) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (French) Currently translated at 98.8% (89 of 90 strings) Translated using Weblate (Japanese) Currently translated at 95.5% (731 of 765 strings) Translated using Weblate (Polish) Currently translated at 56.6% (51 of 90 strings) Translated using Weblate (Bulgarian) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (Chinese (Simplified Han script)) Currently translated at 100.0% (90 of 90 strings) Translated using Weblate (Tamil) Currently translated at 48.8% (44 of 90 strings) Translated using Weblate (Hungarian) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (German) Currently translated at 100.0% (765 of 765 strings) Translated using Weblate (German) Currently translated at 100.0% (90 of 90 strings) Co-authored-by: 439JBYL80IGQTF25UXNR0X1BG <439jbyl80igqtf25uxnr0x1bg@users.noreply.hosted.weblate.org> Co-authored-by: Agnieszka C <aga_04@o2.pl> Co-authored-by: Davit Mayilyan <davit.mayilyan@protonmail.ch> Co-authored-by: Erenay <erenaydev@proton.me> Co-authored-by: Femini <nizamismidov4@gmail.com> Co-authored-by: Fjuro <fjuro@users.noreply.hosted.weblate.org> Co-authored-by: Ghost of Sparta <makesocialfoss32@keemail.me> Co-authored-by: Hosted Weblate <hosted@weblate.org> Co-authored-by: Mickaël Binos <mickaelbinos@outlook.com> Co-authored-by: Milan <mobrcian@hotmail.com> Co-authored-by: Random <random-r@users.noreply.hosted.weblate.org> Co-authored-by: Trunars <trunars@abv.bg> Co-authored-by: VfBFan <vfbfan@users.noreply.hosted.weblate.org> Co-authored-by: justcontributor <kty5663@gmail.com> Co-authored-by: kuragehime <kuragehime641@gmail.com> Co-authored-by: ssantos <ssantos@web.de> Co-authored-by: தமிழ்நேரம் <tamilneram247@gmail.com> Co-authored-by: ℂ𝕠𝕠𝕠𝕝 (𝕘𝕚𝕥𝕙𝕦𝕓.𝕔𝕠𝕞/ℂ𝕠𝕠𝕠𝕝) <coool@mail.lv> Co-authored-by: 大王叫我来巡山 <hamburger2048@users.noreply.hosted.weblate.org> Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/cs/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/de/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/fr/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/ja/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/lv/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/pl/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/sk/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/ta/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/zh_Hans/ Translation: NewPipe/Metadata

Currently translated at 70.0% (63 of 90 strings) Translated using Weblate (Spanish) Currently translated at 100.0% (765 of 765 strings) Co-authored-by: Hosted Weblate <hosted@weblate.org> Co-authored-by: Nicolás Pérez <nicoperez241@proton.me> Co-authored-by: Quý <quycodergithub@gmail.com> Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/vi/ Translation: NewPipe/Metadata

…n-in-not-bot-exception Add link to FAQ entry to "Sign in to confirm not a bot" exception message

Use getApplicationContext() instead of getContext() in ENQUEUE, ENQUEUE_NEXT, START_HERE_ON_BACKGROUND, and START_HERE_ON_POPUP entries to prevent NullPointerException when the fragment's activity context becomes null during configuration changes (e.g. device rotation). The fragment context can become null when the activity is destroyed during rotation, but the async callback from fetchItemInfoIfSparse still holds a reference to the now-detached fragment. Using Application context ensures a stable, non-null context throughout the async operation lifecycle.

Delete untranslated locales

…for-enqueue Fix NullPointerException in enqueue actions by using Application Context

The flag was not passed to the intent that wraps the actual view intent for the app chooser.

To get the changes from TeamNewPipe/NewPipeExtractor#1464

Update extractor to latest commit

Currently translated at 63.3% (57 of 90 strings) Translated using Weblate (Spanish) Currently translated at 100.0% (773 of 773 strings) Translated using Weblate (Chinese (Traditional Han script)) Currently translated at 64.4% (58 of 90 strings) Translated using Weblate (Swedish) Currently translated at 99.8% (772 of 773 strings) Translated using Weblate (Burmese) Currently translated at 1.1% (1 of 90 strings) Translated using Weblate (Latvian) Currently translated at 97.6% (755 of 773 strings) Translated using Weblate (Portuguese) Currently translated at 100.0% (773 of 773 strings) Translated using Weblate (Portuguese (Portugal)) Currently translated at 100.0% (773 of 773 strings) Translated using Weblate (Chinese (Traditional Han script)) Currently translated at 100.0% (773 of 773 strings) Translated using Weblate (Latvian) Currently translated at 97.6% (755 of 773 strings) Translated using Weblate (Latvian) Currently translated at 18.8% (17 of 90 strings) Translated using Weblate (Chinese (Traditional Han script)) Currently translated at 64.4% (58 of 90 strings) Translated using Weblate (Dutch) Currently translated at 100.0% (773 of 773 strings) Translated using Weblate (Russian) Currently translated at 98.8% (764 of 773 strings) Translated using Weblate (Indonesian) Currently translated at 100.0% (773 of 773 strings) Translated using Weblate (Latvian) Currently translated at 97.5% (754 of 773 strings) Deleted translation using Weblate (Aymara (Southern)) Deleted translation using Weblate (Mainfränkisch) Deleted translation using Weblate (Azerbaijani (Southern)) Deleted translation using Weblate (Azerbaijani (Southern)) Deleted translation using Weblate (Kashmiri) Deleted translation using Weblate (Sicilian) Deleted translation using Weblate (Aymara) Deleted translation using Weblate (Luri (Bakhtiari)) Deleted translation using Weblate (Yiddish) Deleted translation using Weblate (Romany) Deleted translation using Weblate (Corsican) Deleted translation using Weblate (Gaelic) Deleted translation using Weblate (Arabic (Tunisian)) Deleted translation using Weblate (French (Louisiana)) Deleted translation using Weblate (German (Low)) Deleted translation using Weblate (English (Old)) Deleted translation using Weblate (English (Middle)) Deleted translation using Weblate (Arabic (Najdi)) Co-authored-by: Arif Budiman <arifpedia@gmail.com> Co-authored-by: Hosted Weblate <hosted@weblate.org> Co-authored-by: Mona Lisa <nickwick@users.noreply.hosted.weblate.org> Co-authored-by: Morkovka21Vek <morkovka21vek@gmail.com> Co-authored-by: Nicolás Pérez <nicoperez241@proton.me> Co-authored-by: Omikorin <git@omikor.in> Co-authored-by: Philip Goto <philip.goto@gmail.com> Co-authored-by: TobiGr <TobiGr@users.noreply.github.com> Co-authored-by: Tun Tun AUNG <tuntunaung@codingclassroom.org> Co-authored-by: UDP <udp@users.noreply.hosted.weblate.org> Co-authored-by: ssantos <ssantos@web.de> Co-authored-by: ℂ𝕠𝕠𝕠𝕝 (𝕘𝕚𝕥𝕙𝕦𝕓.𝕔𝕠𝕞/ℂ𝕠𝕠𝕠𝕝) <coool@mail.lv> Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/lv/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/my/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/pl/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/zh_Hant/ Translation: NewPipe/Metadata

Currently translated at 100.0% (91 of 91 strings) Translated using Weblate (Polish) Currently translated at 63.7% (58 of 91 strings) Co-authored-by: Agnieszka C <aga_04@o2.pl> Co-authored-by: Hosted Weblate <hosted@weblate.org> Co-authored-by: 大王叫我来巡山 <hamburger2048@users.noreply.hosted.weblate.org> Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/pl/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/zh_Hans/ Translation: NewPipe/Metadata

Fix SecurityException when opening downloaded files in other app

TobiGr

thank you

TobiGr and others added 30 commits February 7, 2026 12:36

[DescriptionFragment] Fix thumbnail size: width x height

e6daf45

height x width was used before which is an uncommon order.

Use dedicated constants for unknown image dimensions in ImageStrategy

e358867

Add warning banner about ongoing google certification for android apps

06e4548

Correctly retrieve menu item inside download dialog

195a76b

Merge pull request #13290 from dustdfg/correct_download_fragment

dd65db5

Correctly retrieve menu item inside download dialog

KeepAndroidOpen: Choose website language from list of supported langu…

66237ab

…ages

Merge pull request #13282 from dustdfg/keep_android_open

9f1e2c6

Add warning banner about ongoing google certification for android apps

Don't show Keep Android Open popup on debug builds

042f946

Merge pull request #13292 from dustdfg/kao_release_only

56fb31d

Fix inconsistency in getQuantity and add docs

e22b046

`getQuantity()` was being called in a couple of places with `zeroCaseStringId=0`, but that wasn't documented anywhere, and if `count==0` then `getString(zeroCaseStringId /* == 0 */)` would be returned which doesn't make sense

Merge pull request #13293 from TeamNewPipe/getQuantity-inconsistency

bf16332

Fix inconsistency in getQuantity and add docs

Update NewPipe Extractor to 0.26.0

98a883d

Add changelog for NewPipe 0.28.4 (1009)

8b500c7

Bump version to 0.28.4 (1009)

1fbf9fc

Apply suggestion

0020a02

Merge pull request #13298 from dustdfg/shareutils_kao

0cdf40c

Apply suggestion

8fa6f96

(cherry picked from commit 0020a02)

Merge pull request #13299 from TeamNewPipe/backport-13298-to-release-…

e6e5fc7

…0.28.4

Remove freedroidwarn license

9f45aa5

Maybe this fix ktlint errors?

b8ec9bf

Change URL to FAQ

521f60a

Change to FAQ entry instead

3b3348e

Complete sentence.

47624a5

Merge pull request #13310 from absurdlylongusername/add-issue-url-sig…

05f09c9

…n-in-not-bot-exception Add link to FAQ entry to "Sign in to confirm not a bot" exception message

TobiGr and others added 17 commits March 27, 2026 08:22

Deleted translation using Weblate (Azerbaijani (Southern))

f8c9ab8

Deleted translation using Weblate (Mainfränkisch)

6d50fe7

Deleted translation using Weblate (Aymara (Southern))

75ba70a

Remove French (Lousiana) frc from app locales

da76ddb

Merge pull request #13382 from TeamNewPipe/weblate

b7c339c

Delete untranslated locales

Merge pull request #13385 from arjun1194/fix/use-application-context-…

50e8189

…for-enqueue Fix NullPointerException in enqueue actions by using Application Context

Fix SecurityException when opening downloaded files in other app

db8edd3

The flag was not passed to the intent that wraps the actual view intent for the app chooser.

Update extractor to latest commit

3aa74f1

To get the changes from TeamNewPipe/NewPipeExtractor#1464

Merge pull request #13403 from litetex/update-extractor

2f14473

Update extractor to latest commit

Add changelog for NewPipe 0.28.5 (1010)

0ce141f

Update NewPipe Extractor to v0.26.1

148b6f7

Bump NewPipe version to 0.28.5 (1010)

1ce1dbe

Merge pull request #13391 from TobiGr/fix/downloaderPermission

3e297fd

Fix SecurityException when opening downloaded files in other app

Merge branch 'dev' into refactor

53d8d4d

theimpulson requested review from Stypox and TobiGr April 14, 2026 14:25

github-actions Bot added the size/giant PRs with more than 750 changed lines label Apr 14, 2026

ShareASmile added the rewrite Issues and PRs related to rewrite label Apr 14, 2026

github-project-automation Bot added this to Rewrite Apr 14, 2026

github-project-automation Bot moved this to In Progress in Rewrite Apr 14, 2026

ShareASmile added the code quality Improvements to the codebase to improve the code quality label Apr 14, 2026

TobiGr approved these changes Apr 14, 2026

View reviewed changes

TobiGr merged commit ae03b4f into refactor Apr 14, 2026
6 checks passed

github-project-automation Bot moved this from In Progress to Done in Rewrite Apr 14, 2026

TobiGr mentioned this pull request Apr 14, 2026

Fixed an issue where the download button would crash the app. #13417

Closed

4 tasks

ShareASmile mentioned this pull request Apr 15, 2026

Refactor Nightly crash on download video. #13294

Closed

7 tasks

theimpulson deleted the mergeDev branch April 16, 2026 03:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Merge dev into refactor#13420

Merge dev into refactor#13420
TobiGr merged 85 commits intorefactorfrom
mergeDev

theimpulson commented Apr 14, 2026 •

edited by ShareASmile

Loading

Uh oh!

TobiGr left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Uh oh!

Conversation

theimpulson commented Apr 14, 2026 • edited by ShareASmile Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What is it?

Fixes the following issue(s)

Description of the changes in your PR

APK testing

Due diligence

Uh oh!

TobiGr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

theimpulson commented Apr 14, 2026 •

edited by ShareASmile

Loading