Skip to content

Make prev/next headset buttons configurable#11040

Closed
dvalter wants to merge 1 commit intoTeamNewPipe:devfrom
dvalter:i7880
Closed

Make prev/next headset buttons configurable#11040
dvalter wants to merge 1 commit intoTeamNewPipe:devfrom
dvalter:i7880

Conversation

@dvalter
Copy link
Copy Markdown

@dvalter dvalter commented May 6, 2024

Also changes behavior of A13+ player notification buttons.

and improves

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Before/After Screenshots/Screen Record

  • Before: 1
  • After: 2 3

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@dvalter
Make prev/next headset buttons configurable
e59f934 
Also changes behavior of A13+ player notification buttons.

Fixes TeamNewPipe#7880 and improves TeamNewPipe#9764
@github-actions github-actions Bot added the size/medium PRs with less than 250 changed lines label May 6, 2024
@dvalter
Copy link
Copy Markdown
Author

dvalter commented May 6, 2024

The only drawback is that it's seemingly impossible to change the appearance of the notification buttons on A13 without making all actions custom like in #10580.

However in that case headset functionality can be restored via an overridden MediaButtonEventHandler

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@dvalter
Copy link
Copy Markdown
Author

dvalter commented May 10, 2024

Looks like the tests has failed for some unrelated reasons. One due to some access issues and the other in the test that should not be affected by my changes.

@Profpatsch
Copy link
Copy Markdown
Contributor

Profpatsch commented Nov 18, 2024

Hi @dvalter, I’m sorry nobody has reviewed this yet, but currently we are focusing on a full UI rewrite, which means we are not accepting any feature improvements, only bug requests.

Once that is done, we’d be glad if you could give it another go!

@Profpatsch Profpatsch closed this Nov 18, 2024
@davotoula
Copy link
Copy Markdown

davotoula commented Jun 5, 2025

I was about to start developing this as I also sorely miss this feature.

I will try your branch.

Thanks

@davotoula
Copy link
Copy Markdown

davotoula commented Jun 5, 2025

Rebased on main and works really well. Using this branch as my main. Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size/medium PRs with less than 250 changed lines

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Reassign hardware Next/Prev Buttons

3 participants

@dvalter @Profpatsch @davotoula