Return to portrait after video finish in fullscreen

[niktss]

Checklist

• I am using the latest version - 0.21.0
• I checked, but didn't find any duplicates (open OR closed) of this issue in the repo.
• I have read the contribution guidelines given at https://github.com/TeamNewPipe/NewPipe/blob/HEAD/.github/CONTRIBUTING.md.
• This issue contains only one bug. I will open one issue for every bug report I want to file.

Steps to reproduce the bug

1. Use NewPipe in portrait mode with locked screen rotate
2. Launch a video and press the fullscreen button. Let it finish.

Actual behaviour

The video exits from fullacreen and NewPipe is stuck in landscape. You have to enable autorotate to fix it.

Expected behavior

NewPipe returns to portrait, the mode I launched the video from.

Screenshots/Screen recordings

Logs

Device info

• Android version/Custom ROM version: Lineage 17
• Device model: Galaxy A3(2017)

[sauravrao637]

Hi!
Thanks for reporting the issue and keep doing such good things :)
but it's no bug
I checked this out , if you have auto rotate enabled then the screen will not get stuck but if it's disabled then it's not bug it is the expected behavior.
Please check again on your device and tell if it's not the case

[niktss]

I know about auto rotate working. I was just shocked this is "the expected behaviour". I start fullscreen from portrait, why would I want to go landscape when I exit fullscreen?

[sauravrao637]

If you click again on full screen button , it will exit the full screen . Also you can check its the same case with the official YouTube app.
Let's see what the team has to say :)

[niktss]

I'm not sure if I'm doing it right, but in official YT, when a video is over, it doesn't exit fullscreen, but pressing any button to exit it returns it to portrait. It doesn't force me to use landscape after a video is over though, which is what NewPipe does and to me seems illogical.

If orientation is manually locked by me, and it's in portrait, and I'm therefore using the app in portrait, why would it make sense for it to change to landscape when a video is over in fullscreen? If I browsed to the video in portrait I probably want to browse to the next one in portrait too.

[sauravrao637]

Nor does NewPipe forces you :), if you tap on "full screen icon" you will successfully return to portrait.
When the rotation in locked but you choose fullscreen that means you want to use it in landscape now (in my opinion).
Maybe the team should create a poll regarding the same as all users are different and we should know opinion of the majority and work accordingly :)

[lokesh-krishna]

Glad to see this has already been reported and I'm in agreement. This should definitely not be the expected behaviour. Orientation should go back to portrait upon exiting full screen. Not only that, the UI also seems to get wonky after exiting full screen. Attaching screenshots to explain.

This is what the screen looks like upon first tapping on full screen from portrait. Tapping again goes full screen but upon exiting, this is what I get.

[NanyangTaiji]

Agree with all of you, it is a good suggestion, a simple adustment can fix the issue.

[Dakkaron]

This seems to be only happening in tablet mode (smallest width>=480dp), from my testing.

[lokesh-krishna]

Is it intentional behaviour in tablet mode though? Still seems like a bug. If anything, the fact that this works as expected in phone mode proves the point that what is now happening is not expected behaviour.

You're right about my display density being high though and reducing it did fix the issue for me. Your PR looks like exactly what we need and I hope it is merged soon.

[Dakkaron]

I personally don't think that tablet mode offers much, but it breaks quite a few of my expectations, while phone mode does exactly what I want.

It doesn't seem to me as if it was expected behaviour, but devs say it is.

I find it especially weird that tapping the fullscreen button at first doesn't even open fullscreen, but just toggles the locked orientation. Only the second press opens fullscreen.

Until it is merged you can use the debug build generated from the PR: https://github.com/TeamNewPipe/NewPipe/suites/2474591406/artifacts/53233850

[Dakkaron]

It's actually not possible to go back into portrait mode at all once you triggered this, except by manually unlocking the device rotation or closing NewPipe.
The very strange thing about that is that after triggering this, only NewPipe is stuck in the locked landscape mode. If you tab out of NewPipe, the OS and the other apps are still in locked portrait mode.
It actually took me about two months to figure out how to get out of the locked landscape mode in NewPipe without closing the app.