Skip to content

Video Detail Layout Update#56

Closed
darkon5 wants to merge 25 commits intoTeamNewPipe:masterfrom
darkon5:master
Closed

Video Detail Layout Update#56
darkon5 wants to merge 25 commits intoTeamNewPipe:masterfrom
darkon5:master

Conversation

@darkon5
Copy link
Copy Markdown
Contributor

@darkon5 darkon5 commented Oct 20, 2015

Yay, I made something! Here I have the latest version of my layout for NewPipe. Still a lot to work and learn, but I think it's getting into shape. Changes overall:

It's still a work in progress, I'll keep working on it. Also, in my school we need to make a webpage using HTML and CSS, so I made this: http://dasochan.nl/newpipe/

If the project gets a homepage, I think this one could be a good start :)

That was it for today, g'night! ^.^

@theScrabi
Copy link
Copy Markdown
Member

Sry I didn't notice this earlier. Sorry I broke your pull request. Great work. Cool website. Thanks man :)

@theScrabi
Copy link
Copy Markdown
Member

Hm but could you put the thumbs up and down arrows somewhere else, it looks like they are grading the channel not the video.

@darkon5
Copy link
Copy Markdown
Contributor Author

darkon5 commented Oct 28, 2015

Sure thing, I'll try to fix it today.

@theScrabi
Copy link
Copy Markdown
Member

Again, you may have to stash your changes and do a pull request from the master. I cant merge your branch since we've crashed into each other.
Sry.

@darkon5
Copy link
Copy Markdown
Contributor Author

darkon5 commented Oct 29, 2015

Oh, true. Gotta try to sync it manually then =)

@darkon5
Copy link
Copy Markdown
Contributor Author

darkon5 commented Nov 2, 2015

Okay, I know I shouldn't doing this, but I don't know anyone to ask: When I build the latest version of NewPipe on Android Studio, I get this error:

Error:Execution failed for task ':app:preDexDebug'.
com.android.ide.common.process.ProcessException: org.gradle.process.internal.ExecException: Process 'command 'C:\Program Files\Java\jdk1.8.0_60\bin\java.exe'' finished with non-zero exit value 1

Any idea why this is happening? I technically ported the layout to the new version, but I can't properly test it on my device.

I tried with Java1.8_25, Java1.8_60 and Java1.8_66. Same error.

g'evening! =)

@theScrabi
Copy link
Copy Markdown
Member

Hm. I don't know. But you are using Windows. Maybe you should get rid of that first ;D

@theScrabi
Copy link
Copy Markdown
Member

Madovax recently made changes on the jdk version in the .idea/gradle.xml file:
a18353d
Maybe thats causing your trouble.

@theScrabi
Copy link
Copy Markdown
Member

Ok i think than this is fixed.

@theScrabi theScrabi closed this Nov 10, 2015
@darkon5
Copy link
Copy Markdown
Contributor Author

darkon5 commented Nov 11, 2015

Thanks @chschtsch!

I still have issues with Android Studio, I might do a complete format on my machine.

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants